Skip to content

Rename 'node_coordinates' in theta_nodal_not_ugrid.nc#92

Merged
stephenworsley merged 1 commit into
SciTools:masterfrom
pp-mo:fix_nonugrid
Jul 19, 2024
Merged

Rename 'node_coordinates' in theta_nodal_not_ugrid.nc#92
stephenworsley merged 1 commit into
SciTools:masterfrom
pp-mo:fix_nonugrid

Conversation

@pp-mo

@pp-mo pp-mo commented Jul 17, 2024

Copy link
Copy Markdown
Member

See SciTools/iris#6054

With these changes, Iris will load this file "as-was" (i.e. without UGRID loading enabled),
since we are now permanently enabling ugrid loading.

Renamed the "node_coordinates" attribute of "Mesh0" to "NOT_node_coordinates",
since otherwise the "Mesh0_node_x" and "Mesh0_node_y" are identified as "CFAuxiliaryCoordinateVariable"s,
and this prevents them becoming regular aux-coords, which is required for these tests to function.

@stephenworsley stephenworsley left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@stephenworsley stephenworsley merged commit f724cc6 into SciTools:master Jul 19, 2024
@pp-mo

pp-mo commented Jul 19, 2024

Copy link
Copy Markdown
Member Author

Looks good.

Thanks !
I'll respin SciTools/iris#6054 and we'll see how that goes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants