fixed problem with saving cubes vertical levels but missing orography#1236
Merged
Conversation
Member
Author
|
I feel that this is an urgent fix. Anyone disagree? |
Member
|
👍 |
Member
There was a problem hiding this comment.
This should say "hybrid-height". Amend your commit and I'll push the button. 😄
rhattersley
added a commit
that referenced
this pull request
Jul 17, 2014
fixed problem with saving cubes vertical levels but missing orography
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A change introduced between 1.6 and 1.7 (when we added support for Hybrid pressure) means that loading hybrid height data from PP (or anywhere else) without an orography and then saving it to PP will "unroll" the cube stripping out the vertical level information. This is because the PP save rule checks for the presence of an aux factory rather than the model level, sigma, and level_height coords. This is more flexible as it allows the dependency names (i.e. the formula terms) to have different names. Unfortunately a lot of data lacks the orography and that currently stops the aux factory being created on load. Consequently the vertical coords are not saved. This PR provides a simple (inelegant) fix. See https://github.com/esc24/iris/compare/missing_vertical for a more advanced solution that delegates responsibility to the factory and allows load and save without reference surfaces.
Targets v1.7.x