Skip to content

Fix portability of whatsnew test.#2156

Merged
pelson merged 1 commit into
SciTools:v1.10.xfrom
QuLogic:whatsnew-portability
Oct 6, 2016
Merged

Fix portability of whatsnew test.#2156
pelson merged 1 commit into
SciTools:v1.10.xfrom
QuLogic:whatsnew-portability

Conversation

@QuLogic

@QuLogic QuLogic commented Oct 1, 2016

Copy link
Copy Markdown
Member

Remove unnecessary use of shell=True, and use the correct Python interpreter (i.e., the same one that's running the tests.)

Remove unnecessary use of `shell=True`, and use the correct Python
interpreter (i.e., the same one that's running the tests.)
@QuLogic QuLogic added this to the v1.10.x milestone Oct 1, 2016
@marqh

marqh commented Oct 6, 2016

Copy link
Copy Markdown
Member

Hi @QuLogic

is there a key reason to target 1.10.x for this?

if we do so, are we honour bound to make a 1.10.1 release (not currently planned)?

is it reasonable to target master with this change?

thank you
mark

@ajdawson

ajdawson commented Oct 6, 2016

Copy link
Copy Markdown
Member

if we do so, are we honour bound to make a 1.10.1 release

No, if there ends up being a v1.10.1 then it will get the fix which could be helpful, if not then as long as we merge changes from v1.10.x back into master before cutting the next release branch (which we always should) then it will end up on master anyway.

@marqh

marqh commented Oct 6, 2016

Copy link
Copy Markdown
Member

No, if there ends up being a v1.10.1 then it will get the fix which could be helpful, if not then as long as we merge changes from v1.10.x back into master before cutting the next release branch (which we always should) then it will end up on master anyway.

on that basis I'm happy to accept this as is, perhaps we could merge-back swiftly afterwards, to ensure this is captured?

@ajdawson

ajdawson commented Oct 6, 2016

Copy link
Copy Markdown
Member

perhaps we could merge-back swiftly afterwards

Yes, there is no need to wait.

@pelson

pelson commented Oct 6, 2016

Copy link
Copy Markdown
Member

Thanks @QuLogic. 👍

@pelson pelson merged commit a0940c5 into SciTools:v1.10.x Oct 6, 2016
@QuLogic QuLogic deleted the whatsnew-portability branch October 6, 2016 21:21
@QuLogic

QuLogic commented Oct 7, 2016

Copy link
Copy Markdown
Member Author

is there a key reason to target 1.10.x for this?

Because it's a bug fix and that's the bug fix branch. Just because it's hoped that 1.11 will be the next release, doesn't been it will be. After all, 1.10 took quite a while to eventually come out in shape.

@QuLogic QuLogic modified the milestones: v1.10.x, v1.11 Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants