Skip to content

Document pseudo-level support in structured um loading.#2292

Merged
marqh merged 2 commits into
SciTools:v1.12.xfrom
pp-mo:struct_load_docsfix
Jan 10, 2017
Merged

Document pseudo-level support in structured um loading.#2292
marqh merged 2 commits into
SciTools:v1.12.xfrom
pp-mo:struct_load_docsfix

Conversation

@pp-mo

@pp-mo pp-mo commented Jan 9, 2017

Copy link
Copy Markdown
Member

Just explains the temporary solution introduced in #2274

@pp-mo pp-mo added this to the v1.12.x milestone Jan 9, 2017
@pp-mo pp-mo mentioned this pull request Jan 9, 2017
@pp-mo

pp-mo commented Jan 10, 2017

Copy link
Copy Markdown
Member Author

Problems still to fix.
Fixing ...

@pp-mo pp-mo force-pushed the struct_load_docsfix branch from f5a930d to c63114e Compare January 10, 2017 11:15
@pp-mo

pp-mo commented Jan 10, 2017

Copy link
Copy Markdown
Member Author

... fixed
( but several timeout respins needed 😠 )

Can you check it out @marqh ?

Comment thread lib/iris/fileformats/um/_fast_load.py Outdated

At present, fields with different values of 'LBUSER5'
(pseudo-level) are *also* treated as different phenomena.
This is a temporary fix, standing in place for a more correct

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think i would use the term 'temproary fix'

I would prefer to state what the behaviour is and how it will be experienced.

perhaps
This will result in separate cubes for differnet values of LBUSER, with a coordinate representing the value. These can be concatenated/merged to form cubes with a pseudo level dimension.
or somesuch

@pp-mo pp-mo force-pushed the struct_load_docsfix branch from 611be1e to b8d51ee Compare January 10, 2017 13:33
@marqh marqh merged commit db07769 into SciTools:v1.12.x Jan 10, 2017
@pp-mo pp-mo deleted the struct_load_docsfix branch June 11, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants