Allow missing_value as a user set attribute#2866
Closed
zklaus wants to merge 3 commits into
Closed
Conversation
This allows the user to set missing_value as an attribute on a cube while ensuring that it is saved as local attribute in the netcdf file. Signed-off-by: Klaus Zimmermann <klaus.zimmermann@smhi.se>
pelson
added
the
Blocked: CLA needed
Member
|
Thanks @zklaus. There are some test failures to deal with. For the license tests you just need to change It would be nice to have this new functionality tested too, do you have an idea of how you might do that? |
pelson
added
Blocked: CLA needed
Signed-off-by: Klaus Zimmermann <klaus.zimmermann@smhi.se>
Author
|
Fixed the license issue. I'll add a test while waiting for the answer to my cla. |
This adds missing_value to the list of always data variable attributes in test_attributes. Signed-off-by: Klaus Zimmermann <klaus.zimmermann@smhi.se>
Member
|
Is there any point to targetting the |
Member
|
No, this should be targeted on master. |
Author
|
I created pr #2892 with the same intention, but based on master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the user to set missing_value as an attribute on a
cube while ensuring that it is saved as local attribute in the
netcdf file.
Fixes #1588
Signed-off-by: Klaus Zimmermann klaus.zimmermann@smhi.se