Skip to content

ENH: Working cube data equality#3431

Merged
pp-mo merged 1 commit into
SciTools:masterfrom
cpelley:CUBE_EQUALITY_BOOL_DATA_M
Oct 2, 2019
Merged

ENH: Working cube data equality#3431
pp-mo merged 1 commit into
SciTools:masterfrom
cpelley:CUBE_EQUALITY_BOOL_DATA_M

Conversation

@cpelley

@cpelley cpelley commented Oct 1, 2019

Copy link
Copy Markdown

Replacing #3250 but targeting master.

@cpelley cpelley requested a review from pp-mo October 1, 2019 12:01
@lbdreyer lbdreyer mentioned this pull request Oct 1, 2019
@pp-mo

pp-mo commented Oct 2, 2019

Copy link
Copy Markdown
Member

Hi @cpelley
Regarding : #3433
It looks like this needs to ask for a later version of dask.
I have no idea why that doesn't happen automatically, but it seems we can fix it.

Meanwhile, this branch also needs to cut out the addition to whatsnew/2.2.rst as that is no longer
the appropriate place for it.

Rather than steal more of your time, I'm going to just merge this and retrospectively fix those things.
Thanks for the input !

@pp-mo pp-mo merged commit a52dce2 into SciTools:master Oct 2, 2019
@QuLogic QuLogic added this to the v2.3.0 milestone Oct 3, 2019
@pp-mo pp-mo mentioned this pull request Oct 3, 2019
@cpelley

cpelley commented Nov 22, 2019

Copy link
Copy Markdown
Author

Thanks @pp-mo

@cpelley cpelley deleted the CUBE_EQUALITY_BOOL_DATA_M branch November 22, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants