PI-3473: Netcdf saving of ancillary variables#3550
Merged
Conversation
stickler-ci
reviewed
Nov 18, 2019
Merged
pp-mo
force-pushed
the
ancil_save
branch
2 times, most recently
from
c0c7158 to
c67578f
Compare
Member
Author
|
Hi @stephenworsley |
3 tasks
stephenworsley
left a comment
stephenworsley
left a comment
Contributor
There was a problem hiding this comment.
Just a couple minor things I've noticed on my first pass through the code.
abooton
changed the title
abooton
changed the title
abooton
changed the title
Member
Author
Rebased, and it did fail as predicted 👍 |
stephenworsley
approved these changes
Nov 27, 2019
stephenworsley
left a comment
stephenworsley
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving ancillary variables, with some testcases based on CDL comparisons.
There is some unfinished business here where the tests might be improved,if and when they can use other aspects of ancillary support :UPDATE:
FIxed that.
Nearly good to go?