Don't realise lazy coords in netcdf save.#4397
Merged
Merged
Conversation
pp-mo
commented
Nov 3, 2021
pp-mo
commented
Nov 3, 2021
pp-mo
commented
Nov 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Performance testing revealed that the recent changes to stream all lazy data in netcdf saves didn't quite fix the problem of realising lazy coordinates, as intended
I.E. nc-save is still loading all lazy aux-coords into memory.
So this fixes that, and adds a test to ensure the behaviour.
Consult Iris pull request check list