Skip to content

Fixed copyright date on one of the tests.#483

Merged
esc24 merged 1 commit into
SciTools:masterfrom
pelson:license_header_check
May 1, 2013
Merged

Fixed copyright date on one of the tests.#483
esc24 merged 1 commit into
SciTools:masterfrom
pelson:license_header_check

Conversation

@pelson

@pelson pelson commented May 1, 2013

Copy link
Copy Markdown
Member

No description provided.

esc24 added a commit that referenced this pull request May 1, 2013
Fixed copyright date on one of the tests.
@esc24 esc24 merged commit 041b111 into SciTools:master May 1, 2013
@rhattersley

Copy link
Copy Markdown
Member

I must be misunderstanding something... I thought that header was added automatically by #477? So I'm surprised there isn't a fix in this PR for that.

@esc24

esc24 commented May 1, 2013

Copy link
Copy Markdown
Member

I'm fairly sure the license checking will need a series of bugfixes as we use it. For example, I'm looking at #475 and it's passing (on my local machine using an up to date upstream/master) despite the license headers not being updated. I'll raise an issue when I'm a bit more sure of what's going on.

@esc24

esc24 commented May 1, 2013

Copy link
Copy Markdown
Member

Just spotted the issue. It's a logic error in the dictionary construction in #477. Apologies for missing it in the review. I'll submit a PR.

@pelson

pelson commented May 1, 2013

Copy link
Copy Markdown
Member Author

I thought that header was added automatically by #477? So I'm surprised there isn't a fix in this PR for that.

The header is not automatically added - it is simply checked that it exists and that the last commit year co-insides with the last year in the header. There is no first date checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants