Skip to content

Sample code to convert ORCA data into a meshcube.#5013

Merged
trexfeathers merged 3 commits into
SciTools:mainfrom
pp-mo:orca_mesh_example
Oct 6, 2022
Merged

Sample code to convert ORCA data into a meshcube.#5013
trexfeathers merged 3 commits into
SciTools:mainfrom
pp-mo:orca_mesh_example

Conversation

@pp-mo

@pp-mo pp-mo commented Oct 4, 2022

Copy link
Copy Markdown
Member

Fulfils a long-ago promise to write up + share how to make meshes for ORCA data.

Test docs-build of this branch, showing : the new section

@trexfeathers trexfeathers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't read through yet, but the image doesn't fit with the others on the page. The other images prioritise showing the kind of grid/mesh that's being converted, even if the image is not part of the script. Could you find something illustrative of an ORCA grid, either from the Internet or using GeoVista?

@pp-mo

pp-mo commented Oct 5, 2022

Copy link
Copy Markdown
Member Author

I haven't read through yet, but the image doesn't fit with the others on the page.

Okay, that is a good call !
I've now replaced that image with something hopefully more suitable.

N.B. now also provided a test docs-build here

@trexfeathers trexfeathers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @pp-mo!

Definitely deserves a What's New entry

@trexfeathers

Copy link
Copy Markdown
Contributor

GHA is being weird. I'm merging anyway - the offending job passed for previous near-identical commits AND passes for other Python versions.

@trexfeathers trexfeathers merged commit 959b590 into SciTools:main Oct 6, 2022
@pp-mo

pp-mo commented Oct 6, 2022

Copy link
Copy Markdown
Member Author

Unfortunately RTD seems to not like my cross-link.
But weirdly my local Sphinx build does get it right.
So I'm experimenting with a fix ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants