Skip to content

V3.7.x.updates#5424

Merged
pp-mo merged 4 commits into
SciTools:v3.7.xfrom
pp-mo:v3.7.x.updates
Aug 16, 2023
Merged

V3.7.x.updates#5424
pp-mo merged 4 commits into
SciTools:v3.7.xfrom
pp-mo:v3.7.x.updates

Conversation

@pp-mo

@pp-mo pp-mo commented Aug 16, 2023

Copy link
Copy Markdown
Member

Whatsnew text finalisation + renames, suitable for release branch docs

@pp-mo pp-mo requested a review from HGWright August 16, 2023 13:12
@pp-mo

pp-mo commented Aug 16, 2023

Copy link
Copy Markdown
Member Author

Hi @HGWright
Named you again !
Please see if you like this. Especially, check out the docs (from the tests tick, when they've built)

This step is almost entirely about getting the docs to look right.
FWIW I'm not totally happy about the "no major highlights", but I can't see what else to say.
If you think it looks better, we can remove the highlights section altogether for this one.

@pp-mo pp-mo marked this pull request as draft August 16, 2023 13:19
@pp-mo

pp-mo commented Aug 16, 2023

Copy link
Copy Markdown
Member Author

Sorry, please hold off. Fixing a docs-build problem ...
(converted to Draft)

@codecov

codecov Bot commented Aug 16, 2023

Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (8361532) 89.37% compared to head (b6ce933) 89.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##           v3.7.x    #5424   +/-   ##
=======================================
  Coverage   89.37%   89.37%           
=======================================
  Files          89       89           
  Lines       22443    22443           
  Branches     5381     5381           
=======================================
  Hits        20058    20058           
  Misses       1639     1639           
  Partials      746      746           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pp-mo pp-mo marked this pull request as ready for review August 16, 2023 13:28
@pp-mo

pp-mo commented Aug 16, 2023

Copy link
Copy Markdown
Member Author

Ok fixed !
Here's the whats-new from the built docs : https://scitools-iris--5424.org.readthedocs.build/en/5424/whatsnew/index.html

Please review @HGWright !

@HGWright HGWright left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see RTD working on this PR. I think that there are 2 option with regards to the 'Major Highlights' of the release, and I will leave the decision to you @pp-mo.

  1. Leave it as is, because there is nothing of the size that usually constitutes a major highlight.
  2. Take the oppertunity to highlight some more niche but still good/important changes.

@pp-mo

pp-mo commented Aug 16, 2023

Copy link
Copy Markdown
Member Author

Ok thanks @HGWright
See what you think of this approach ...

@HGWright

Copy link
Copy Markdown
Contributor

Looks better! Very happy for this to be merged.

@pp-mo

pp-mo commented Aug 16, 2023

Copy link
Copy Markdown
Member Author

Looks better! Very happy for this to be merged.

Great, thanks.
I think that's all it needs, for now.

@pp-mo pp-mo merged commit 75ff780 into SciTools:v3.7.x Aug 16, 2023
@pp-mo pp-mo deleted the v3.7.x.updates branch August 31, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants