Add option to specify chunks in iris.util.broadcast_to_shape#5620
Merged
HGWright merged 2 commits intoApr 5, 2024
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5620 +/- ##
==========================================
+ Coverage 89.69% 89.76% +0.07%
==========================================
Files 90 93 +3
Lines 22809 22990 +181
Branches 5440 5010 -430
==========================================
+ Hits 20458 20638 +180
- Misses 1618 1622 +4
+ Partials 733 730 -3 ☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
bouweandela
force-pushed
the
broadcast-to-shape-with-chunks
branch
4 times, most recently
from
4e5e5b1 to
479f021
Compare
bouweandela
force-pushed
the
broadcast-to-shape-with-chunks
branch
from
479f021 to
dcf9df8
Compare
bouweandela
force-pushed
the
broadcast-to-shape-with-chunks
branch
from
a8d3008 to
3754eb3
Compare
bouweandela
added a commit
to ESMValGroup/ESMValCore
that referenced
this pull request
Jan 16, 2024
Contributor
|
@pp-mo any update on this? |
Member
Sorry yes I am reviewing this, I have some queries + suggestions pending . |
HGWright
requested changes
Apr 4, 2024
HGWright
approved these changes
Apr 5, 2024
HGWright
left a comment
HGWright
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the changes @bouweandela! Looks good to me.
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Apr 10, 2024
…th_numpydoc * upstream/main: (39 commits) Bump scitools/workflows from 2024.03.3 to 2024.04.0 (SciTools#5907) [pre-commit.ci] pre-commit autoupdate (SciTools#5906) Updated environment lockfiles (SciTools#5904) Ignore flaticon.com in linkchecks. (SciTools#5905) Implement lazy area weights (SciTools#5658) Add option to specify chunks in `iris.util.broadcast_to_shape` (SciTools#5620) Unpin sphinx (SciTools#5901) DOC: clarify save_pairs_from_cube docstring (SciTools#5783) Restore latest Whats New files. Whats new updates for `v3.9.0rc0` (SciTools#5899) nep29: drop py39 and support py312 (SciTools#5894) Support NetCDF v3 files in chunking control code. (SciTools#5897) Avoid computing lazy scalar coordinates when printing a Cube (v2) (SciTools#5896) Force pytest colour output on GitHub Actions (SciTools#5895) Make typing 3.9 compatible. Improve typing readability. Updated environment lockfiles (SciTools#5892) [pre-commit.ci] pre-commit autoupdate What's New entry for SciTools#5740 . Iris to GeoVista conversion (SciTools#5740) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Make it possible to specify the target chunks in iris.util.broadcast_to_shape.
This function is often used to broadcast auxiliary coordinate or cell measure data or weights to the same shape as the data from a cube. If the chunks of the broadcasted data do not match that of the cube, this leads to poor computational performance. Rechunking after broadcasting is less efficient, therefore it is really useful to be able to specify the chunks directly as part of the broadcast.
Closes #5456
Consult Iris pull request check list