Simplify data fixtures.#5838
Merged
bjlittle merged 2 commits intoMar 14, 2024
Merged
Conversation
74bf624 to
b49a508
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## FEATURE_pytest_conversion #5838 +/- ##
=============================================================
- Coverage 89.74% 89.74% -0.01%
=============================================================
Files 92 92
Lines 22942 22940 -2
Branches 5464 5462 -2
=============================================================
- Hits 20590 20588 -2
Misses 1620 1620
Partials 732 732 ☔ View full report in Codecov by Sentry. |
bjlittle
approved these changes
Mar 14, 2024
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-on to #5834
Following a discussion on simpler solutions to migrating setUp functions..
This effectively reverts some of the tweaks in the previous : makes fewer diffs from the original unittest form.
May be slightly pointless, but the new way will be easier to follow in the eventual feature merge-back.