Convert tests/unit/mesh to PyTest.#6631
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6631 +/- ##
==========================================
+ Coverage 89.95% 90.00% +0.04%
==========================================
Files 91 91
Lines 24447 24447
Branches 4567 4567
==========================================
+ Hits 21992 22004 +12
+ Misses 1686 1676 -10
+ Partials 769 767 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ESadek-MO
requested changes
Aug 12, 2025
ESadek-MO
left a comment
Contributor
There was a problem hiding this comment.
Please could you change the unittest.mock calls in test_MeshCoord?
Dir as a whole looks good, a couple of changes. There are one or two comments which are just comments, not change requests, feel free to resolve those once you've read them.
There're some massive files, which possibly haven't had great attention to detail from me, but I think it's 80 to 20.
Contributor
Author
|
Thanks @ESadek-MO, looks like a dropped the ball quite a bit there. |
ESadek-MO
requested changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_MeshXYwas a mess (my fault originally. I've done my best to find a pattern that limits the changes, to help with reviewing.