Convert tests/unit/fileformats/cf mesh content to PyTest#6633
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6633 +/- ##
=======================================
Coverage 89.95% 89.95%
=======================================
Files 91 91
Lines 24447 24447
Branches 4567 4567
=======================================
Hits 21992 21992
Misses 1686 1686
Partials 769 769 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ESadek-MO
requested changes
Aug 12, 2025
ESadek-MO
left a comment
Contributor
There was a problem hiding this comment.
Please could you:
- correct the mock calls in test_CFReader and test_CFGroup
- remove the commented code in test_CFReader (line 370. _setup)
Feel free to veto if I'm pushing further out of scope.
Contributor
Author
Veto please. You're re-reviewing work that has already been approved as part of the conversion project: #5873 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The other content in the directory has already been converted.