Skip to content

Convert tests/unit/fileformats/cf mesh content to PyTest#6633

Merged
ESadek-MO merged 3 commits into
SciTools:mainfrom
trexfeathers:pytest_unit_cfugrid
Aug 12, 2025
Merged

Convert tests/unit/fileformats/cf mesh content to PyTest#6633
ESadek-MO merged 3 commits into
SciTools:mainfrom
trexfeathers:pytest_unit_cfugrid

Conversation

@trexfeathers

Copy link
Copy Markdown
Contributor

The other content in the directory has already been converted.

@codecov

codecov Bot commented Aug 11, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.95%. Comparing base (e4caaee) to head (76833f8).
⚠️ Report is 109 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6633   +/-   ##
=======================================
  Coverage   89.95%   89.95%           
=======================================
  Files          91       91           
  Lines       24447    24447           
  Branches     4567     4567           
=======================================
  Hits        21992    21992           
  Misses       1686     1686           
  Partials      769      769           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ESadek-MO ESadek-MO left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you:

  • correct the mock calls in test_CFReader and test_CFGroup
  • remove the commented code in test_CFReader (line 370. _setup)

Feel free to veto if I'm pushing further out of scope.

@trexfeathers

trexfeathers commented Aug 12, 2025

Copy link
Copy Markdown
Contributor Author

Please could you:

  • correct the mock calls in test_CFReader and test_CFGroup
  • remove the commented code in test_CFReader (line 370. _setup)

Feel free to veto if I'm pushing further out of scope.

Veto please. You're re-reviewing work that has already been approved as part of the conversion project: #5873

@ESadek-MO ESadek-MO left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with your changes, I'll add the others to #6625

@ESadek-MO ESadek-MO merged commit 33ba668 into SciTools:main Aug 12, 2025
26 checks passed
@trexfeathers trexfeathers deleted the pytest_unit_cfugrid branch August 22, 2025 13:53
@scitools-ci scitools-ci Bot removed this from 🚴 Peloton Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants