Expand the Nimrod loader to include Tables 1, 3 & 4#6763
Merged
Conversation
trexfeathers
previously requested changes
Oct 28, 2025
trexfeathers
left a comment
trexfeathers
left a comment
Contributor
There was a problem hiding this comment.
Thanks @HGWright; here are some comments for you.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6763 +/- ##
==========================================
- Coverage 90.43% 90.20% -0.23%
==========================================
Files 91 91
Lines 24839 24885 +46
Branches 4656 4672 +16
==========================================
- Hits 22463 22448 -15
- Misses 1608 1667 +59
- Partials 768 770 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
HGWright
force-pushed
the
nimrod_tables
branch
from
441485f to
37dc8ce
Compare
HGWright
changed the title
HGWright
changed the title
HGWright
added
the
benchmark_this
Contributor
⏱️ Performance Benchmark Report: 6047a02Performance shiftsFull benchmark resultsGenerated by GHA run |
ESadek-MO
requested changes
Feb 9, 2026
ESadek-MO
left a comment
ESadek-MO
left a comment
Contributor
There was a problem hiding this comment.
Just one suggestion on wording. Otherwise will be good to go (with a whatsnew either here on on a new PR)
Co-authored-by: Elias <110238618+ESadek-MO@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This adds onto the existing code, and seperates things between Table 1 and Table 2 that was always treated as default before.
Table 1 is now the default and Tables 2, 3 and 4 can be accessed when certain conditions are met.
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: