Compatibility with NetCDF4 v1.7.3 and unpin Dask#6827
Merged
Conversation
trexfeathers
force-pushed
the
dataset_iterable
branch
from
1af8153 to
b4ac2d6
Compare
github-actions
Bot
added
the
benchmark_this
trexfeathers
force-pushed
the
dataset_iterable
branch
from
b4ac2d6 to
8216c89
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3.14.x #6827 +/- ##
========================================
Coverage 90.39% 90.39%
========================================
Files 91 91
Lines 24766 24766
Branches 4640 4640
========================================
Hits 22387 22387
Misses 1608 1608
Partials 771 771 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
⏱️ Performance Benchmark Report: a49d2b0Performance shiftsFull benchmark resultsGenerated by GHA run |
Contributor
⏱️ Performance Benchmark Report: 117679ePerformance shiftsFull benchmark resultsGenerated by GHA run |
stephenworsley
approved these changes
Dec 3, 2025
stephenworsley
left a comment
stephenworsley
left a comment
Contributor
There was a problem hiding this comment.
Looks good, though I would note that the whatsnew may end up conflicting with #6817.
trexfeathers
force-pushed
the
dataset_iterable
branch
from
8216c89 to
01cb92b
Compare
trexfeathers
changed the title
trexfeathers
force-pushed
the
dataset_iterable
branch
from
01cb92b to
4f6bb8b
Compare
Contributor
⏱️ Performance Benchmark Report: 2c35a63Performance shiftsFull benchmark resultsGenerated by GHA run |
Contributor
⏱️ Performance Benchmark Report: be3dc2dPerformance shiftsFull benchmark resultsGenerated by GHA run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
The
Datasetobject is now similar tostrin that it is iterable but we do not want to iterate over it.I'm uncertain how to demonstrate this since it seems inappropriate to regenerate lock files on a release branch?EDIT: will update the lock files in an independent commit. PR should then be merged using a merge-commit to disambiguate the conflict we'll get during merge-back.Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: