Skip to content

Convert fileformats/nc_load_rules to pytest#6896

Merged
HGWright merged 19 commits into
SciTools:mainfrom
ESadek-MO:pt-ff-nc_load_rules
Feb 5, 2026
Merged

Convert fileformats/nc_load_rules to pytest#6896
HGWright merged 19 commits into
SciTools:mainfrom
ESadek-MO:pt-ff-nc_load_rules

Conversation

@ESadek-MO

Copy link
Copy Markdown
Contributor

🚀 Pull Request

Description


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

@codecov

codecov Bot commented Jan 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.18%. Comparing base (aebae6d) to head (72516b8).
⚠️ Report is 62 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6896   +/-   ##
=======================================
  Coverage   90.18%   90.18%           
=======================================
  Files          91       91           
  Lines       24822    24822           
  Branches     4656     4656           
=======================================
  Hits        22385    22385           
  Misses       1669     1669           
  Partials      768      768           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HGWright HGWright left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing to change in a few places, from the ruff check --select PT then this is good to go.

Comment thread lib/iris/tests/unit/fileformats/nc_load_rules/helpers/test_build_and_add_names.py Outdated
Comment thread lib/iris/tests/unit/fileformats/nc_load_rules/helpers/test_build_and_add_units.py Outdated
Comment thread lib/iris/tests/unit/fileformats/nc_load_rules/helpers/test_build_and_add_units.py Outdated

@HGWright HGWright left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ESadek-MO

@HGWright HGWright merged commit ec2e6af into SciTools:main Feb 5, 2026
22 checks passed
@scitools-ci scitools-ci Bot removed this from 🚴 Peloton Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants