Converted fileformats/pp to pytest#6904
Merged
Merged
Conversation
HGWright
requested changes
Jan 30, 2026
HGWright
left a comment
Contributor
There was a problem hiding this comment.
A few small changes, that should also fix the tests on this PR.
Worth noting that there are some PT ruff checks still failing after these changes:
PT031
PT006
PT011
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6904 +/- ##
=======================================
Coverage 90.18% 90.18%
=======================================
Files 91 91
Lines 24822 24822
Branches 4656 4656
=======================================
Hits 22385 22385
Misses 1669 1669
Partials 768 768 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
THere's a todo I've left. Technically, unittest.mock is still allowable, but more importantly it creates a problem I can't solve if I remove it.