Skip to content

Converted fileformats/pp to pytest#6904

Merged
HGWright merged 16 commits into
SciTools:mainfrom
ESadek-MO:pt-ff-pp
Feb 6, 2026
Merged

Converted fileformats/pp to pytest#6904
HGWright merged 16 commits into
SciTools:mainfrom
ESadek-MO:pt-ff-pp

Conversation

@ESadek-MO

Copy link
Copy Markdown
Contributor

🚀 Pull Request

Description

THere's a todo I've left. Technically, unittest.mock is still allowable, but more importantly it creates a problem I can't solve if I remove it.

@HGWright HGWright left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes, that should also fix the tests on this PR.

Worth noting that there are some PT ruff checks still failing after these changes:

PT031
PT006
PT011

Comment thread lib/iris/tests/unit/fileformats/pp/test_PPField.py Outdated
Comment thread lib/iris/tests/unit/fileformats/pp/test_save.py
Comment thread lib/iris/tests/unit/fileformats/pp/test_save.py
Comment thread lib/iris/tests/unit/fileformats/pp/test__field_gen.py Outdated
Comment thread lib/iris/tests/unit/fileformats/pp/test_save.py Outdated
@codecov

codecov Bot commented Feb 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.18%. Comparing base (ec2e6af) to head (e678bb8).
⚠️ Report is 58 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6904   +/-   ##
=======================================
  Coverage   90.18%   90.18%           
=======================================
  Files          91       91           
  Lines       24822    24822           
  Branches     4656     4656           
=======================================
  Hits        22385    22385           
  Misses       1669     1669           
  Partials      768      768           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HGWright HGWright left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ESadek-MO

@HGWright HGWright merged commit dc4cd76 into SciTools:main Feb 6, 2026
22 checks passed
@scitools-ci scitools-ci Bot removed this from 🚴 Peloton Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants