Fixed all ruff PT failures

[ESadek-MO]

🚀 Pull Request

Description

• PT018 x 2
• PT013 x 1
• PT011 x 158
• PT006 x 19
• PT007 x 4
• PT019 x 10 This needs to remain ignored, explanation below.

IrisTest and test_IrisTest will need exclusions
Related to #6212.

[scitools-ci]

Templating

This PR includes changes that may be worth sharing via templating. For each file listed below, please either:

• Action the suggestion via a pull request editing/adding the relevant file in the SciTools/.github templates/ directory. ¹
• Raise an issue against the SciTools/.github repo for the above action if you really don't have 10mins spare right now. Include an assignee, to avoid it being forgotten.
• Dismiss the suggestion if the changes are not suitable for templating.

You will need to dismiss this review before this PR can be merged. Recommend the reviewer does this as their final action before merging, as this text will continually update as commits come in.

Template candidates

The following changed files are not currently templated, but their parent directories suggest they may be good candidates for a new template to be created:

• .ruff.toml

Footnotes

1. Include this text in the PR body to avoid any notifications about applying the template changes back to the source repo!
   @scitools-templating: please no update notification on: iris ↩

[ESadek-MO]

PT019 will fail due to the way I've approached context managers. They're wrapped in fixture-factories, which return a context manager. However, ruff doesn't consider with fixture_return_func do: to be using fixture_return_func, and so demands we put it in a @pytest...usefixture(); this would fail.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.20%. Comparing base (d0edcb5) to head (1743d0a).
⚠️ Report is 51 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6939   +/-   ##
=======================================
  Coverage   90.20%   90.20%           
=======================================
  Files          91       91           
  Lines       24885    24886    +1     
  Branches     4672     4672           
=======================================
+ Hits        22448    22449    +1     
  Misses       1667     1667           
  Partials      770      770           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[scitools-ci]

Templating

This PR includes changes that may be worth sharing via templating. For each file listed below, please either:

• Action the suggestion via a pull request editing/adding the relevant file in the SciTools/.github templates/ directory. ¹
• Raise an issue against the SciTools/.github repo for the above action if you really don't have 10mins spare right now. Include an assignee, to avoid it being forgotten.
• Dismiss the suggestion if the changes are not suitable for templating.

You will need to dismiss this review before this PR can be merged. Recommend the reviewer does this as their final action before merging, as this text will continually update as commits come in.

Templated files

The following changed files are templated:

• pyproject.toml, templated by SciTools/.github/templates/pyproject.toml

Template candidates

The following changed files are not currently templated, but their parent directories suggest they may be good candidates for a new template to be created:

• .ruff.toml

Footnotes

1. Include this text in the PR body to avoid any notifications about applying the template changes back to the source repo!
   @scitools-templating: please no update notification on: iris ↩

[trexfeathers]

😎

These changes are Iris-specific