MigratorTrait with self

[tyt2y3]

#2803

[tyt2y3]

@ctron can you try this and see if it works for you?

use crate::common::migration::*;
use sea_orm_migration::{MigratorTraitSelf, prelude::*};

pub struct Migrator {
    pub i: i32,
}

#[async_trait::async_trait]
impl MigratorTraitSelf for Migrator {
    fn migrations(&self) -> Vec<Box<dyn MigrationTrait>> {
        vec![
            Box::new(m20220118_000001_create_cake_table::Migration),
            Box::new(m20220118_000002_create_fruit_table::Migration),
        ]
    }
}

[patch.crates-io]
sea-orm-migration = { git = "https://github.com/SeaQL/sea-orm", branch = "migrator-self" }

[ctron]

I won't be able to actually try it out this week. But taking a quick look, that looks very promising. As the MigrationTrait already uses self, I should be able to pass in arguments to the actual migration. And so that should work!

[tyt2y3]

thanks, please give it a try and let me know. want to have some user feedback before merging this in.

[tyt2y3]

@ctron got any fun?

[ctron]

@ctron got any fun?

I'm so sorry. Especially as you came up with a quick fix like that. But I wasn't able to test it yet. It's still on my todo list, as this problem still persists and we do need a fix. So it still is relevant.

[tyt2y3]

no problem, I've rebased the branch

[ctron]

Finally had some time to check this out. Yes, having this would be awesome!

[tyt2y3]

I hope there's no conflict!

[github-actions]

🎉 Released In 2.0.0-rc.32 🎉

Huge thanks for the contribution!
This feature has now been released, so it's a great time to upgrade.
Show some love with a ⭐ on our repo, every star counts!