Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions compiler/rustc_mir_transform/src/liveness.rs
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,7 @@ fn maybe_drop_guard<'tcx>(
matches!(
ty.kind(),
ty::Closure(..)
| ty::CoroutineClosure(..)
| ty::Coroutine(..)
| ty::Tuple(..)
| ty::Adt(..)
Expand Down
25 changes: 25 additions & 0 deletions tests/ui/async-await/async-closures/liveness-drop-guard.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
// Regression test for #479: maybe_drop_guard missing CoroutineClosure in type list.
// Before the fix, async closures holding Drop types could produce false
// "unused variable" warnings because liveness analysis did not recognize
// CoroutineClosure as a type that may have drop guards.

//@ edition:2021
//@ check-pass

#![deny(unused_variables)]

struct NeedsDrop(i32);

impl Drop for NeedsDrop {
fn drop(&mut self) {}
}

fn main() {
let _ = async {
let d = NeedsDrop(1);
let c = async move || {
let _ = &d;
};
c().await;
};
}