Add "no-origin" flag in order to work better with Entra desktop apps#131
Add "no-origin" flag in order to work better with Entra desktop apps#131mbilski merged 1 commit intoSecureAuthCorp:masterfrom
Conversation
|
Hi @markdespain Thank you for your PR. Although this is a valid fix, I started wondering if always adding the Origin headers makes sense. Please take a look at #108 and #109 Perhaps it would be better to introduce a slight breaking change, and instead of adding a What do you think? |
|
Hi @mbilski , Thanks for taking a look.
I haven't looked deeply into this consideration, but my understanding of OAuth is that the Origin header is not always required. Though, there seem to be case where it must be and where it must not be, as can be seen across this PR and those you've shared. For my case, my application is registered as "Mobile and desktop application"... i.e. not running brower. So, for that case I can rationalize why Entra might not want an Origin header for that case.
Solution-wise, I'm flexible and am happy to defer to you and any broader concensus. I can easily flip the logic of my PR to implement |
|
Just touching base, @mbilski . Do you by chance have a suggestion based on my reply? |
mbilski
left a comment
There was a problem hiding this comment.
@markdespain sorry for the late response, let's go with the --no-origin flag
All good! Appreciate the responses, and thanks for approving! |
Greetings!
I discovered oauth2c today, and it is was exactly what I was looking for.
However, I have an app in Entra that is registed as a desktop application that uses the "authorization code flow with PKCE", and I'd like to be able to get an access token for it.
Unfornately, I discoved that
In order to help oauth2c support my use case, this PR adds a
--no-originflag, to indicate that the Origin header not be emitted (see After farther below). Though, do let me know if they may be another way to handle this, as there could easily be something I've overlooked.Cheers!
Before
... the response is like so...
After: using new --no-origin flag
As a result an access token can be successfully obtained for my Entra app: