This repository was archived by the owner on Jan 13, 2022. It is now read-only.
Add TLS/SASL support#2
Merged
Merged
Conversation
- Fix version regex
- Add additional SASL TLS parameter
adamgilbert
reviewed
Oct 25, 2018
| postconf -F smtp/unix/chroot=n | ||
|
|
||
| if [[ "${POSTFIX_TLS}" = "true" ]]; then | ||
| echo "Configuring TLS" |
There was a problem hiding this comment.
Antonia has been bugging me lately about using single quotes for echo statements and variables that require no interpolation. This is a real bike shed discussion on style but it would be good to pick a direction going forward.
Collaborator
Author
There was a problem hiding this comment.
I agree with using the correct quotes interpolating vs. not... I'll fix
Collaborator
Author
There was a problem hiding this comment.
Hmm.. shellcheck should catch this I think
adamgilbert
approved these changes
Oct 25, 2018
adamgilbert
left a comment
adamgilbert
left a comment
There was a problem hiding this comment.
+1 aside from a simple comment on style.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.