[py] remove xfail attr for firefox and safari for cookie tests#14794
Merged
diemol merged 5 commits intoSeleniumHQ:trunkfrom Dec 28, 2024
Merged
[py] remove xfail attr for firefox and safari for cookie tests#14794diemol merged 5 commits intoSeleniumHQ:trunkfrom
diemol merged 5 commits intoSeleniumHQ:trunkfrom
Conversation
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Contributor
PR Code Suggestions ✨No code suggestions found for the PR. |
Member
|
The common test has been removed from the test matrix for safari since it took 3 hours to complete. selenium/.github/workflows/ci-python.yml Line 126 in 4b7d174 |
Member
Author
|
I will try to see what can be done. |
Member
Author
|
I wasn't able to find a way to optimise this. A workaround for this can be simply skipping this in the CI like it's done for other tests I believe. |
8 tasks
diemol
approved these changes
Dec 28, 2024
sandeepsuryaprasad
pushed a commit
to sandeepsuryaprasad/selenium
that referenced
this pull request
Mar 23, 2025
…iumHQ#14794) [py] remove xfail attr for firefox and safari Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Removes
@pytest.mark.xfail_safariand@pytest.mark.xfail_firefoxattribute for python cookie testsMotivation and Context
As per the docs and tested locally the attribute is no longer needed and can be tested with Safari and FireFox
Types of changes
Checklist
PR Type
Bug fix, Tests
Description
@pytest.mark.xfail_firefoxand@pytest.mark.xfail_safaridecorators from cookie tests, allowing them to run on Firefox and Safari without expected failures.sameSitecookie attribute is now supported in these browsers, aligning with local testing results.Changes walkthrough 📝
cookie_tests.py
Remove xfail markers for Firefox and Safari in cookie testspy/test/selenium/webdriver/common/cookie_tests.py
@pytest.mark.xfail_firefoxdecorator from tests.@pytest.mark.xfail_safaridecorator from tests.