[dotnet] Revert deprecation of GetAttribute method#14956
Merged
nvborisenko merged 1 commit intoSeleniumHQ:trunkfrom Dec 27, 2024
Merged
[dotnet] Revert deprecation of GetAttribute method#14956nvborisenko merged 1 commit intoSeleniumHQ:trunkfrom
nvborisenko merged 1 commit intoSeleniumHQ:trunkfrom
Conversation
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Contributor
PR Code Suggestions ✨No code suggestions found for the PR. |
sandeepsuryaprasad
pushed a commit
to sandeepsuryaprasad/selenium
that referenced
this pull request
Mar 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Description
It reverts
GetAttributedeprecation for .NETMotivation and Context
To be aligned with all bindings.
Types of changes
Checklist
PR Type
Enhancement
Description
GetAttributemethod across the .NET bindingObsoleteattribute fromGetAttributemethod in three key classes:EventFiringWebDriverIWebElementinterfaceWebElementclassGetAttributeas a supported methodChanges walkthrough 📝
EventFiringWebDriver.cs
Remove GetAttribute deprecation in EventFiringWebDriverdotnet/src/support/Events/EventFiringWebDriver.cs
Obsoleteattribute from theGetAttributemethod in theEventFiringWebDriverclassIWebElement.cs
Remove GetAttribute deprecation in IWebElement interfacedotnet/src/webdriver/IWebElement.cs
Obsoleteattribute from theGetAttributemethod in theIWebElementinterfaceWebElement.cs
Remove GetAttribute deprecation in WebElement classdotnet/src/webdriver/WebElement.cs
Obsoleteattribute from theGetAttributemethod in theWebElementclass