[dotnet] Apply formatting on internal CDP generator#15049
Merged
nvborisenko merged 2 commits intoSeleniumHQ:trunkfrom Jan 10, 2025
Merged
[dotnet] Apply formatting on internal CDP generator#15049nvborisenko merged 2 commits intoSeleniumHQ:trunkfrom
nvborisenko merged 2 commits intoSeleniumHQ:trunkfrom
Conversation
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Contributor
PR Code Suggestions ✨No code suggestions found for the PR. |
sandeepsuryaprasad
pushed a commit
to sandeepsuryaprasad/selenium
that referenced
this pull request
Mar 23, 2025
gryznar
pushed a commit
to gryznar/selenium
that referenced
this pull request
May 17, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
enhancement
Description
Refactored property declarations to use auto-properties.
Replaced
Stringwithstringfor consistency.Added null checks and improved exception handling.
Improved formatting and readability of the codebase.
Changes walkthrough 📝
26 files
Refactored property declarations and formattingRefactored property declarations and formattingRefactored property declarations and formattingSimplified property getters using expression-bodied membersRefactored property declarationsAdded null checks and improved formattingRefactored property declarationsAdded null checks and improved formattingAdded null checks and improved formattingRefactored property declarationsAdded null checks for settings parameterImproved formatting and added null checksSimplified property getters and added null checksAdded null checks and improved formattingRefactored property declarationsImproved null checks and formattingSimplified property getter and added exceptionReplaced `String` with `string` for consistencyRefactored property declarationsRefactored property declarationsRefactored property declarationsRefactored property declarationsRefactored property declarations and improved formattingSimplified property getters and added exception handlingRefactored property declarations and improved formattingRefactored property declarations and improved formatting