Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 15 additions & 33 deletions dotnet/src/webdriver/Chromium/ChromiumDriver.cs
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@
using OpenQA.Selenium.DevTools;
using OpenQA.Selenium.Remote;

#pragma warning disable CS0618 // Obsolete members are used internally

namespace OpenQA.Selenium.Chromium;

/// <summary>
Expand All @@ -34,93 +32,77 @@ public class ChromiumDriver : WebDriver, ISupportsLogs, IDevTools
/// <summary>
/// Accept untrusted SSL Certificates
/// </summary>
[Obsolete("This field will be made protected in v4.44.")]
// When make it protected don't forget to remove pragma warning disable CS0618 and the Obsolete attribute from this field.
public static readonly bool AcceptUntrustedCertificates = true;
protected static readonly bool AcceptUntrustedCertificates = true;
Comment thread
nvborisenko marked this conversation as resolved.

/// <summary>
/// Command for executing a Chrome DevTools Protocol command in a driver for a Chromium-based browser.
/// </summary>
[Obsolete("This field will be made protected in v4.44.")]
public static readonly string ExecuteCdp = "executeCdpCommand";
protected static readonly string ExecuteCdp = "executeCdpCommand";

/// <summary>
/// Command for getting cast sinks in a driver for a Chromium-based browser.
/// </summary>
[Obsolete("This field will be made protected in v4.44.")]
public static readonly string GetCastSinksCommand = "getCastSinks";
protected static readonly string GetCastSinksCommand = "getCastSinks";

/// <summary>
/// Command for selecting a cast sink in a driver for a Chromium-based browser.
/// </summary>
[Obsolete("This field will be made protected in v4.44.")]
public static readonly string SelectCastSinkCommand = "selectCastSink";
protected static readonly string SelectCastSinkCommand = "selectCastSink";

/// <summary>
/// Command for starting cast tab mirroring in a driver for a Chromium-based browser.
/// </summary>
[Obsolete("This field will be made protected in v4.44.")]
public static readonly string StartCastTabMirroringCommand = "startCastTabMirroring";
protected static readonly string StartCastTabMirroringCommand = "startCastTabMirroring";

/// <summary>
/// Command for starting cast desktop mirroring in a driver for a Chromium-based browser.
/// </summary>
[Obsolete("This field will be made protected in v4.44.")]
public static readonly string StartCastDesktopMirroringCommand = "startCastDesktopMirroring";
protected static readonly string StartCastDesktopMirroringCommand = "startCastDesktopMirroring";

/// <summary>
/// Command for getting a cast issued message in a driver for a Chromium-based browser.
/// </summary>
[Obsolete("This field will be made protected in v4.44.")]
public static readonly string GetCastIssueMessageCommand = "getCastIssueMessage";
protected static readonly string GetCastIssueMessageCommand = "getCastIssueMessage";

/// <summary>
/// Command for stopping casting in a driver for a Chromium-based browser.
/// </summary>
[Obsolete("This field will be made protected in v4.44.")]
public static readonly string StopCastingCommand = "stopCasting";
protected static readonly string StopCastingCommand = "stopCasting";

/// <summary>
/// Command for getting the simulated network conditions in a driver for a Chromium-based browser.
/// </summary>
[Obsolete("This field will be made protected in v4.44.")]
public static readonly string GetNetworkConditionsCommand = "getNetworkConditions";
protected static readonly string GetNetworkConditionsCommand = "getNetworkConditions";

/// <summary>
/// Command for setting the simulated network conditions in a driver for a Chromium-based browser.
/// </summary>
[Obsolete("This field will be made protected in v4.44.")]
public static readonly string SetNetworkConditionsCommand = "setNetworkConditions";
protected static readonly string SetNetworkConditionsCommand = "setNetworkConditions";

/// <summary>
/// Command for deleting the simulated network conditions in a driver for a Chromium-based browser.
/// </summary>
[Obsolete("This field will be made protected in v4.44.")]
public static readonly string DeleteNetworkConditionsCommand = "deleteNetworkConditions";
protected static readonly string DeleteNetworkConditionsCommand = "deleteNetworkConditions";

/// <summary>
/// Command for executing a Chrome DevTools Protocol command in a driver for a Chromium-based browser.
/// </summary>
[Obsolete("This field will be made protected in v4.44.")]
public static readonly string SendChromeCommand = "sendChromeCommand";
protected static readonly string SendChromeCommand = "sendChromeCommand";

/// <summary>
/// Command for executing a Chrome DevTools Protocol command that returns a result in a driver for a Chromium-based browser.
/// </summary>
[Obsolete("This field will be made protected in v4.44.")]
public static readonly string SendChromeCommandWithResult = "sendChromeCommandWithResult";
protected static readonly string SendChromeCommandWithResult = "sendChromeCommandWithResult";

/// <summary>
/// Command for launching an app in a driver for a Chromium-based browser.
/// </summary>
[Obsolete("This field will be made protected in v4.44.")]
public static readonly string LaunchAppCommand = "launchAppCommand";
protected static readonly string LaunchAppCommand = "launchAppCommand";

/// <summary>
/// Command for setting permissions in a driver for a Chromium-based browser.
/// </summary>
[Obsolete("This field will be made protected in v4.44.")]
public static readonly string SetPermissionCommand = "setPermission";
protected static readonly string SetPermissionCommand = "setPermission";

private readonly string optionsCapabilityName;
private DevToolsSession? devToolsSession;
Expand Down
11 changes: 0 additions & 11 deletions dotnet/src/webdriver/DriverService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -191,17 +191,6 @@ public async ValueTask DisposeAsync()
GC.SuppressFinalize(this);
}

/// <summary>
Comment thread
nvborisenko marked this conversation as resolved.
/// Starts the driver service if it is not already running.
/// </summary>
/// <exception cref="InvalidOperationException">If the driver service path is specified but the driver service executable name is not.</exception>
/// <exception cref="WebDriverException">If the service fails to initialize within the timeout period or exits unexpectedly.</exception>
[Obsolete("Use StartAsync(CancellationToken) instead. This method will be removed in a future release (4.43).")]
public void Start()
{
this.StartAsync().GetAwaiter().GetResult();
}

/// <summary>
/// Starts the driver service if it is not already running.
/// </summary>
Expand Down
32 changes: 0 additions & 32 deletions dotnet/src/webdriver/Remote/ICommandServer.cs

This file was deleted.

Loading