Frankkim/update tap to store nested data as jsonb field - #1
Merged
francisace merged 4 commits intoNov 1, 2023
Merged
Conversation
clarkeRS
self-requested a review
November 1, 2023 19:58
clarkeRS
approved these changes
Nov 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description for
target-postgresTitle
Disable Table De-Nesting and Store All Nested JSON Objects in JSONB Columns
Description
Summary
This Pull Request addresses the handling of nested JSON objects in
target-postgres. Instead of de-nesting the tables, all nested structures—including arrays—will now be stored directly in JSONB columns.Motivation
Handling nested objects by creating separate tables (de-nesting) can result in a complex schema that's hard to manage and query. By storing the nested objects directly as JSONB, we simplify the schema and make it easier to query nested data.
Changes
How it works
Here is an example to illustrate the new behavior:
Previous Behavior
For a JSON payload like the following:
{ "name": "John", "info": { "email": "john@example.com", "address": { "city": "NY", "state": "NY" } } }The data would be saved in multiple tables, such as main_table, info_table, and address_table.
New Behavior
Now, the data will be saved in a single table with JSONB columns: