feat(Dropdown): add allowReselection prop#4450
Open
ilyaliao wants to merge 1 commit intoSemantic-Org:masterfrom
Open
feat(Dropdown): add allowReselection prop#4450ilyaliao wants to merge 1 commit intoSemantic-Org:masterfrom
ilyaliao wants to merge 1 commit intoSemantic-Org:masterfrom
Conversation
|
💖 Thanks for opening this pull request! 💖 Here is a list of things that will help get it across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4450 +/- ##
==========================================
- Coverage 99.51% 99.51% -0.01%
==========================================
Files 186 186
Lines 3512 3511 -1
==========================================
- Hits 3495 3494 -1
Misses 17 17 ☔ View full report in Codecov by Sentry. |
|
Has any progress been made on the review of this pull request? I ran across the same issue in my app. It would be handy to have this patch in to allow for reselection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4415
This PR adds the allowReselection prop to the Dropdown. This enables user to trigger onChange events even when reselecting same value.
I think I've resolved the issue. If there are any omissions or areas that need modification, feel free to provide suggestions!