docs(sidebar): improve readability and contrast at 910px#4534
Open
shhreya13 wants to merge 1 commit intoSemantic-Org:masterfrom
Open
docs(sidebar): improve readability and contrast at 910px#4534shhreya13 wants to merge 1 commit intoSemantic-Org:masterfrom
shhreya13 wants to merge 1 commit intoSemantic-Org:masterfrom
Conversation
|
@shhreya13 is attempting to deploy a commit to the Semantic UI Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4534 +/- ##
=======================================
Coverage 99.53% 99.53%
=======================================
Files 186 186
Lines 3463 3463
=======================================
Hits 3447 3447
Misses 16 16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the readability and visual hierarchy of the documentation sidebar for medium-width viewports (~768px to 991px). It addresses specifically reported issues regarding small font sizes, cramped spacing, and low text contrast at approximately 910px.
Changes
Typography: Increased the base font size for menu items to 14px and sub-menu items to 13px to improve legibility on dark backgrounds.
Spacing: Adjusted line-height to 1.6 and increased vertical padding to 0.9em to reduce visual density and improve the interactive "hit area" for navigation links.
Visual Hierarchy: Enhanced section headers (e.g., "Elements", "Collections") by increasing font size to 1.1em and setting color to pure white (#fff).
Accessibility: Increased the text contrast of nested menu items to rgba(255, 255, 255, 0.8) to ensure compliance with WCAG AA standards for text on dark backgrounds.
Responsive Design: Implemented these changes via a targeted @media query in docs/src/Style.js to ensure the layout remains balanced as the viewport scales.
Environment
Version: 3.0.0-beta.2
Tested on: Chrome 130 (Windows 11) at ~910px