Skip to content

F-025: fix(app): log Ctrl+C handler install failures #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sephyi wants to merge 1 commit into
base: development
Choose a base branch
from
Open

F-025: fix(app): log Ctrl+C handler install failures #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/app.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,10 @@ impl App {
// Setup Ctrl+C handler with CancellationToken
let cancel = self.cancel_token.clone();
tokio::spawn(async move {
signal::ctrl_c().await.ok();
if let Err(e) = signal::ctrl_c().await {
warn!(error = %e, "failed to install Ctrl+C handler");
return;
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Ctrl+C handler setup failure, the spawned task returns without cancelling. This changes behavior vs the previous .ok() (which would still call cancel.cancel() after an immediate Err), and can leave the app running without any CancellationToken-based shutdown path (streaming tasks may keep going, and Ctrl+C may no longer trigger graceful cancellation). Consider cancelling after logging (to preserve the prior fail-fast behavior) or surfacing this as a fatal startup error instead of silently continuing.

Suggested change
return;

Copilot uses AI. Check for mistakes.
}
cancel.cancel();
});

Expand Down
Loading