fix(mac): sidebar disclosure triangle overlapping row content - #459
Merged
Conversation
…ow content The AppKit sidebar draws its own trailing chevron per expandable row, but NSOutlineView still rendered its built-in leading disclosure triangle for every expandable item. With flat indentation (indentationPerLevel == 0) that triangle landed directly on top of the status rail, and every expandable row showed two chevrons. Suppress the built-in cell via frameOfOutlineCell. Section headers are pinned open (setExpansion no-ops for them), so their chevron was an inert control; hide it. Also widen the trailing stack spacing so run-tape cells stop reading as part of the adjacent badge. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every expandable sidebar row rendered two chevrons: the row view's own trailing chevron plus NSOutlineView's built-in leading disclosure triangle. Because the outline uses flat indentation (
indentationPerLevel == 0) with row-view-managed insets, the built-in triangle rendered directly on top of the status rail at the leading edge.Section headers ("Projects") additionally showed a permanently-frozen chevron: sections are pinned open (
setExpansionno-ops for.section), so the control was inert.Fix
SidebarNativeOutlineView.frameOfOutlineCell(atRow:)returns.zero— suppresses the built-in triangle; expansion still works through the row chevron, keyboard, and programmatic paths (sections keepisExpandable == trueso their children render).Verification
SERGECODE_UI_PROBE_SCENARIO=sidebar-outline— assertions pass; capture shows single trailing chevron per row, clean status rails.SERGECODE_UI_PROBE_SCENARIO=sidebar-menus— all row menus still open (assertions pass).pnpm run verify— pass.🤖 Generated with Claude Code