Extend add_linear_biases to support a dictionary of sub-layers to which linear bias should be added.#158
Closed
bigximik wants to merge 2 commits into
Closed
Extend add_linear_biases to support a dictionary of sub-layers to which linear bias should be added.#158bigximik wants to merge 2 commits into
bigximik wants to merge 2 commits into
Conversation
Collaborator
Author
|
I have two questions:
|
Collaborator
|
Thanks @bigximik. Do we need regex pattern matching for Qwen2 for layer-wise application of linear biases? I thought that Qwen2 used bias terms in all q,k,v layers, so this feature is technically not needed, or is it? |
Collaborator
Author
|
Qwen2 does not need it. I made it generic to be more in line with #155 |
Collaborator
Author
|
This will be in draft, for Qwen2 support this is implemented in a while #160 |
Collaborator
|
I think #168 will make these kinds of things unnecessary? |
Collaborator
|
closing this since we are going forward with #242 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description
A possibility to specify the addition of linear biases per layer and
attentionandmlpsub-layers in the form of a dictionary, with sub-layer keys and their presence in layers, like this:🔍 Type of change
Select all that apply:
📝 Changes
List the key changes introduced in this PR:
add_linear_biasesas dict✅ Checklist
Make sure the following tasks are completed before submitting the PR:
General
Testing