Apriel SSM/Hybrid#258
Merged
Merged
Conversation
jlamypoirier
approved these changes
Jun 4, 2025
Collaborator
jlamypoirier
left a comment
There was a problem hiding this comment.
Is this ready to merge?
Contributor
Author
|
@jlamypoirier apologies for delayed reply, yes, it should be ready. Just need to run local tests and verify everything is ok, will merge after. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description
This pr improves some minor things in SSM/Hybrid classes, adds functionality for loading and exporting Apriel SSM and hybrid SSM models (adds corresponding modeling.py classes), adds
embeddings_lr_scaleargument🔍 Type of change
Select all that apply:
📝 Changes
List the key changes introduced in this PR:
embeddings_lr_scaleoutput_lr_scale✅ Checklist
Make sure the following tasks are completed before submitting the PR:
General
Dependencies and Configuration
Testing
Performance Impact
📊 Performance Impact Details
🗒️ Additional Notes