Skip to content

Fix backward compatibility in normalization #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlamypoirier merged 1 commit into from
Oct 16, 2024
Merged

Fix backward compatibility in normalization #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions fast_llm/layers/language_model/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,20 @@ def use_absolute_position_embeddings(self):
# TODO: Set through num embeddings instead instead.
return self.use_position_embeddings

@classmethod
def from_flat_dict(
cls,
default: dict[str],
strict: bool = True,
):
# The backward compatibility fix in `NormalizationArchitectureConfig`
# won't work for older checkpoints saved with a flat config.
# TODO v0.2: Remove flat format
cls._handle_renamed_field(default, "normalization_type", "type")
cls._handle_renamed_field(default, "layer_norm_eps", "epsilon")
cls._handle_renamed_field(default, "zero_centered_normalization", "zero_centered")
return super().from_flat_dict(default, strict)


@config_class()
class LanguageModelBaseConfig(LanguageModelArchitectureConfig, BaseModelConfig):
Expand Down