Skip to content

fix z loss keyword arg #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tscholak merged 1 commit into from
Nov 20, 2024
Merged

fix z loss keyword arg #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fast_llm/layers/common/auxiliary_loss.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def z_loss(
logits_scale_factor: float = 1.0,
) -> torch.Tensor:
if losses is not None or (training and grad_scale is not None):
loss = calculate_z_loss(logits, logit_scale_factor=logits_scale_factor)
loss = calculate_z_loss(logits, logits_scale_factor=logits_scale_factor)
if losses is not None and loss_name is not None:
losses[loss_name].append(loss.detach())
if training and grad_scale is not None:
Expand Down