Fix static call#7
Merged
Merged
Conversation
tscholak
approved these changes
Oct 17, 2024
| commits = [c.split(" ", 1)[1] for c in commits] | ||
| # Keep commits corresponding to a new iter | ||
| return [iter_number for c in commits if (iter_number := self.get_iter_number(c)) is not None] | ||
| return [iter_number for c in commits if (iter_number := PushConfig._get_iter_number(c)) is not None] |
Collaborator
There was a problem hiding this comment.
minor nitpick: this should probably a class method instead of a static method. Then:
Suggested change
| return [iter_number for c in commits if (iter_number := PushConfig._get_iter_number(c)) is not None] | |
| return [iter_number for c in commits if (iter_number := cls._get_iter_number(c)) is not None] |
Contributor
Author
There was a problem hiding this comment.
@tscholak cls not defined? or are you suggesting to change _get_commited_iter_numbers to class a method and use self?
Contributor
Author
There was a problem hiding this comment.
Thanks made the method into a classmethod.
jlamypoirier
added a commit
that referenced
this pull request
May 6, 2026
- Drop unused self._preprocessing_config store in Trainer.setup. - Replace torch.ones + index_add_ with torch.bincount for tok_sum in fused_gspo_loss_forward_backward. - Drop load-bearing-sounding docs_per_step reference from the normalize_by_documents field description (no cross-config check exists to enforce it). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.