fix(PerpV2BasisTradingModule): External audit fixes for low-risk findings and Internal audit fixes - #232

Merged

0xSachinK merged 16 commits into

sachin/btm-external-audit-fixes-2

Apr 13, 2022

Commits on Apr 12, 2022

Design Improvement: Cache storage slot values
0xSachinK
committed
da37a4e
Design Improvements: Spelling and grammar
0xSachinK
committed
cbe59b6
Fix typo
0xSachinK
committed
9b12b68
Fix revert statement
0xSachinK
committed
fc3c4d5
Design improvement: Return early if no funding will be withdrawn
0xSachinK
committed
cb97742
Fix coverage: Add test case for when notionalFunding is zero
0xSachinK
committed
ac8ee8c
Fix failing test
0xSachinK
committed
003e093
Modify calculateExternalPositionUnit logic used by deposit and withdraw; Reduce bytecodesize
0xSachinK
committed
70128d2
Override withdraw function to track settled funding
0xSachinK
committed
2fb338b
Fix deposit; Add check to ensure deposit unit is <= current unit; Add tests
0xSachinK
committed
b7ca3b8
Refactor update external position unit logic; Add tests
0xSachinK
committed
9a5cb81
Fix tests; And skip 2 getRedemptionAdjustments tests
0xSachinK
committed
44af665
Add internal audit fixes and suggestions
0xSachinK
committed
90b0276
Fix division by zero error
0xSachinK
committed
56bfe82

Commits on Apr 13, 2022

fix(tests): Small fixes for BasisTradingModule audit changes (#243)
cgewecke
authored
58113aa
Remove .skip; Fix javadocs
0xSachinK
committed
fc701d7