[Stagging] Aurora tweaks by tdavidcl · Pull Request #1625 · Shamrock-code/Shamrock

tdavidcl · 2026-02-08T19:21:04Z

No description provided.

gemini-code-assist · 2026-02-08T19:21:20Z

Summary of Changes

Hello @tdavidcl, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the debugging and observability capabilities within the codebase. It introduces an enhancement to the SourceLocation utility by allowing it to carry an optional descriptive message. This new feature is then integrated into the shamalgs::write_buf function to provide more comprehensive and contextual logging during buffer write operations, which will significantly aid in diagnosing issues and understanding data flow.

Highlights

Enhanced SourceLocation: The SourceLocation struct has been extended to include an optional std::string message, allowing developers to attach custom contextual information to source code locations for improved debugging.
Improved Logging Output: The format_one_line_func method within SourceLocation now conditionally includes the new optional message in its output, providing richer and more descriptive log entries when available.
Detailed write_buf Tracing: The shamalgs::write_buf function now leverages the enhanced SourceLocation to capture and log detailed state information, such as buffer length, size, current head, offset, and access pointers, at various critical stages of its execution. This provides deeper insights into buffer operations.

Changelog

src/shamalgs/include/shamalgs/serialize.hpp
- Added std::string info variables to capture detailed state parameters within the write_buf function.
- Integrated StackEntry objects with the new SourceLocation constructor, passing contextual info messages at multiple points in write_buf.
src/shambase/include/shambase/SourceLocation.hpp
- Included the <optional> header for std::optional.
- Added std::optional<std::string> message as a new member to the SourceLocation struct.
- Modified the SourceLocation constructor to accept an optional std::string message as its first argument.
src/shambase/src/SourceLocation.cpp
- Updated SourceLocation::format_one_line_func() to conditionally include the message in the formatted output if it has a value, providing more informative log lines.

Activity

No human activity (comments, reviews, approvals) has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces changes to add detailed messages to stack traces, which is used for debugging in serialize.hpp. My review focuses on two main points:

The implementation of the new tracing in serialize.hpp is very verbose and looks like temporary debugging code. I've suggested either removing it or refactoring it into a macro for better readability if it's intended to be a permanent feature.
The constructor for SourceLocation has been modified in a way that breaks backward compatibility. I've proposed a solution using overloaded constructors to add the new functionality without breaking existing code.

gemini-code-assist · 2026-02-08T19:23:08Z

src/shambase/include/shambase/SourceLocation.hpp

+    std::optional<std::string> message;

-    inline explicit SourceLocation(srcloc _loc = srcloc::current()) : loc(_loc) {}
+    inline explicit SourceLocation(std::optional<std::string> _message = std::nullopt,srcloc _loc = srcloc::current()) : loc(_loc), message(_message) {}


The change to the SourceLocation constructor is a breaking API change. Code that previously compiled, such as SourceLocation(my_srcloc_object), will now fail. To add support for an optional message while maintaining backward compatibility, it's better to use overloaded constructors.

Suggested change

inline explicit SourceLocation(std::optional<std::string> _message = std::nullopt,srcloc _loc = srcloc::current()) : loc(_loc), message(_message) {}

inline explicit SourceLocation(srcloc _loc = srcloc::current()) : loc(_loc), message(std::nullopt) {}

inline explicit SourceLocation(std::string _message, srcloc _loc = srcloc::current()) : loc(_loc), message(std::move(_message)) {}

src/shamalgs/include/shamalgs/serialize.hpp

github-actions · 2026-02-08T19:46:15Z

Thanks @tdavidcl for opening this PR!

You can do multiple things directly here:
1 - Comment pre-commit.ci run to run pre-commit checks.
2 - Comment pre-commit.ci autofix to apply fixes.
3 - Add label autofix.ci to fix authorship & pre-commit for every commit made.
4 - Add label light-ci to only trigger a reduced & faster version of the CI (need the full one before merge).
5 - Add label trigger-ci to create an empty commit to trigger the CI.

Once the workflow completes a message will appear displaying informations related to the run.

Also the PR gets automatically reviewed by gemini, you can:
1 - Comment /gemini review to trigger a review
2 - Comment /gemini summary for a summary
3 - Tag it using @gemini-code-assist either in the PR or in review comments on files

github-actions · 2026-02-28T14:55:19Z

Workflow report

workflow report corresponding to commit 10f743a
Commiter email is timothee.davidcleris@proton.me

Light CI is enabled. This will only run the basic tests and not the full tests.
Merging a PR require the job "on PR / all" to pass which is disabled in this case.

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks................................................Passed
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
ruff check...............................................................Passed
ruff format..............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed
No UTF-8 in files (except for authors)...................................Passed

Test pipeline can run.

Doxygen diff with `main`

Removed warnings : 23
New warnings : 24
Warnings count : 8187 → 8188 (0.0%)

Detailed changes :

- src/shamalgs/include/shamalgs/serialize.hpp:373: warning: Member load_buf(sham::DeviceBuffer< T > &buf, u64 len) (function) of class shamalgs::SerializeHelper is not documented.
+ src/shamalgs/include/shamalgs/serialize.hpp:413: warning: Member load_buf(sham::DeviceBuffer< T > &buf, u64 len) (function) of class shamalgs::SerializeHelper is not documented.
- src/shambase/include/shambase/SourceLocation.hpp:32: warning: Member srcloc (typedef) of struct SourceLocation is not documented.
+ src/shambase/include/shambase/SourceLocation.hpp:33: warning: Member srcloc (typedef) of struct SourceLocation is not documented.
- src/shambase/include/shambase/SourceLocation.hpp:34: warning: Member loc (variable) of struct SourceLocation is not documented.
+ src/shambase/include/shambase/SourceLocation.hpp:35: warning: Member loc (variable) of struct SourceLocation is not documented.
- src/shambase/include/shambase/SourceLocation.hpp:36: warning: Member SourceLocation(srcloc _loc=srcloc::current()) (function) of struct SourceLocation is not documented.
+ src/shambase/include/shambase/SourceLocation.hpp:36: warning: Member message (variable) of struct SourceLocation is not documented.
+ src/shambase/include/shambase/SourceLocation.hpp:38: warning: Member SourceLocation(std::optional< std::string > _message=std::nullopt, srcloc _loc=srcloc::current()) (function) of struct SourceLocation is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/setup/GeneratorLatticeHCP.hpp:29: warning: Compound shammodels::sph::modules::GeneratorLatticeHCP is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/setup/GeneratorLatticeHCP.hpp:45: warning: Compound shammodels::sph::modules::GeneratorLatticeHCP is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/setup/GeneratorLatticeHCP.hpp:49: warning: Member GeneratorLatticeHCP(ShamrockCtx &context, Tscal dr, std::pair< Tvec, Tvec > box) (function) of class shammodels::sph::modules::GeneratorLatticeHCP is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/setup/GeneratorLatticeHCP.hpp:65: warning: Member GeneratorLatticeHCP(ShamrockCtx &context, Tscal dr, std::pair< Tvec, Tvec > box) (function) of class shammodels::sph::modules::GeneratorLatticeHCP is not documented.
- src/shamrock/src/scheduler/SchedulerPatchData.cpp:249: warning: Member split_patchdata(shamrock::patch::PatchDataLayer &original_pd, const shamrock::patch::SimulationBoxInfo &sim_box, const std::array< shamrock::patch::Patch, 8 > patches, std::array< std::reference_wrapper< shamrock::patch::PatchDataLayer >, 8 > pdats) (function) of namespace shamrock::scheduler is not documented.
+ src/shamrock/src/scheduler/SchedulerPatchData.cpp:256: warning: Member split_patchdata(shamrock::patch::PatchDataLayer &original_pd, const shamrock::patch::SimulationBoxInfo &sim_box, const std::array< shamrock::patch::Patch, 8 > patches, std::array< std::reference_wrapper< shamrock::patch::PatchDataLayer >, 8 > pdats) (function) of namespace shamrock::scheduler is not documented.
- src/shamrock/src/scheduler/SchedulerPatchData.cpp:272: warning: Member split_patchdata< f32_3 >(shamrock::patch::PatchDataLayer &original_pd, const shamrock::patch::SimulationBoxInfo &sim_box, const std::array< shamrock::patch::Patch, 8 > patches, std::array< std::reference_wrapper< shamrock::patch::PatchDataLayer >, 8 > pdats) (function) of namespace shamrock::scheduler is not documented.
- src/shamrock/src/scheduler/SchedulerPatchData.cpp:278: warning: Member split_patchdata< f64_3 >(shamrock::patch::PatchDataLayer &original_pd, const shamrock::patch::SimulationBoxInfo &sim_box, const std::array< shamrock::patch::Patch, 8 > patches, std::array< std::reference_wrapper< shamrock::patch::PatchDataLayer >, 8 > pdats) (function) of namespace shamrock::scheduler is not documented.
+ src/shamrock/src/scheduler/SchedulerPatchData.cpp:279: warning: Member split_patchdata< f32_3 >(shamrock::patch::PatchDataLayer &original_pd, const shamrock::patch::SimulationBoxInfo &sim_box, const std::array< shamrock::patch::Patch, 8 > patches, std::array< std::reference_wrapper< shamrock::patch::PatchDataLayer >, 8 > pdats) (function) of namespace shamrock::scheduler is not documented.
- src/shamrock/src/scheduler/SchedulerPatchData.cpp:284: warning: Member split_patchdata< u32_3 >(shamrock::patch::PatchDataLayer &original_pd, const shamrock::patch::SimulationBoxInfo &sim_box, const std::array< shamrock::patch::Patch, 8 > patches, std::array< std::reference_wrapper< shamrock::patch::PatchDataLayer >, 8 > pdats) (function) of namespace shamrock::scheduler is not documented.
+ src/shamrock/src/scheduler/SchedulerPatchData.cpp:285: warning: Member split_patchdata< f64_3 >(shamrock::patch::PatchDataLayer &original_pd, const shamrock::patch::SimulationBoxInfo &sim_box, const std::array< shamrock::patch::Patch, 8 > patches, std::array< std::reference_wrapper< shamrock::patch::PatchDataLayer >, 8 > pdats) (function) of namespace shamrock::scheduler is not documented.
- src/shamrock/src/scheduler/SchedulerPatchData.cpp:290: warning: Member split_patchdata< u64_3 >(shamrock::patch::PatchDataLayer &original_pd, const shamrock::patch::SimulationBoxInfo &sim_box, const std::array< shamrock::patch::Patch, 8 > patches, std::array< std::reference_wrapper< shamrock::patch::PatchDataLayer >, 8 > pdats) (function) of namespace shamrock::scheduler is not documented.
+ src/shamrock/src/scheduler/SchedulerPatchData.cpp:291: warning: Member split_patchdata< u32_3 >(shamrock::patch::PatchDataLayer &original_pd, const shamrock::patch::SimulationBoxInfo &sim_box, const std::array< shamrock::patch::Patch, 8 > patches, std::array< std::reference_wrapper< shamrock::patch::PatchDataLayer >, 8 > pdats) (function) of namespace shamrock::scheduler is not documented.
- src/shamrock/src/scheduler/SchedulerPatchData.cpp:296: warning: Member split_patchdata< i64_3 >(shamrock::patch::PatchDataLayer &original_pd, const shamrock::patch::SimulationBoxInfo &sim_box, const std::array< shamrock::patch::Patch, 8 > patches, std::array< std::reference_wrapper< shamrock::patch::PatchDataLayer >, 8 > pdats) (function) of namespace shamrock::scheduler is not documented.
+ src/shamrock/src/scheduler/SchedulerPatchData.cpp:297: warning: Member split_patchdata< u64_3 >(shamrock::patch::PatchDataLayer &original_pd, const shamrock::patch::SimulationBoxInfo &sim_box, const std::array< shamrock::patch::Patch, 8 > patches, std::array< std::reference_wrapper< shamrock::patch::PatchDataLayer >, 8 > pdats) (function) of namespace shamrock::scheduler is not documented.
+ src/shamrock/src/scheduler/SchedulerPatchData.cpp:303: warning: Member split_patchdata< i64_3 >(shamrock::patch::PatchDataLayer &original_pd, const shamrock::patch::SimulationBoxInfo &sim_box, const std::array< shamrock::patch::Patch, 8 > patches, std::array< std::reference_wrapper< shamrock::patch::PatchDataLayer >, 8 > pdats) (function) of namespace shamrock::scheduler is not documented.
- src/shamrock/src/scheduler/SchedulerPatchData.cpp:39: warning: Compound shamrock::scheduler::Message is not documented.
+ src/shamrock/src/scheduler/SchedulerPatchData.cpp:40: warning: Compound shamrock::scheduler::Message is not documented.
- src/shamrock/src/scheduler/SchedulerPatchData.cpp:40: warning: Member buf (variable) of struct shamrock::scheduler::Message is not documented.
+ src/shamrock/src/scheduler/SchedulerPatchData.cpp:41: warning: Member buf (variable) of struct shamrock::scheduler::Message is not documented.
- src/shamrock/src/scheduler/SchedulerPatchData.cpp:41: warning: Member rank (variable) of struct shamrock::scheduler::Message is not documented.
+ src/shamrock/src/scheduler/SchedulerPatchData.cpp:42: warning: Member rank (variable) of struct shamrock::scheduler::Message is not documented.
- src/shamrock/src/scheduler/SchedulerPatchData.cpp:42: warning: Member tag (variable) of struct shamrock::scheduler::Message is not documented.
+ src/shamrock/src/scheduler/SchedulerPatchData.cpp:43: warning: Member tag (variable) of struct shamrock::scheduler::Message is not documented.
- src/shamrock/src/scheduler/SchedulerPatchData.cpp:45: warning: Member send_messages(std::vector< Message > &msgs, std::vector< MPI_Request > &rqs) (function) of namespace shamrock::scheduler is not documented.
+ src/shamrock/src/scheduler/SchedulerPatchData.cpp:46: warning: Member send_messages(std::vector< Message > &msgs, std::vector< MPI_Request > &rqs) (function) of namespace shamrock::scheduler is not documented.
- src/shamrock/src/scheduler/SchedulerPatchData.cpp:73: warning: Member recv_probe_messages(std::vector< Message > &msgs, std::vector< MPI_Request > &rqs) (function) of namespace shamrock::scheduler is not documented.
+ src/shamrock/src/scheduler/SchedulerPatchData.cpp:74: warning: Member recv_probe_messages(std::vector< Message > &msgs, std::vector< MPI_Request > &rqs) (function) of namespace shamrock::scheduler is not documented.
+ src/shamsys/src/SignalCatch.cpp:106: warning: Member register_signals() (function) of namespace shamsys is not documented.
+ src/shamsys/src/SignalCatch.cpp:106: warning: Member register_signals() (function) of namespace shamsys is not documented.
+ src/shamsys/src/SignalCatch.cpp:106: warning: Member register_signals() (function) of namespace shamsys is not documented.
- src/shamsys/src/SignalCatch.cpp:24: warning: Member signal_callback_handler(int signum) (function) of namespace shamsys::details is not documented.
- src/shamsys/src/SignalCatch.cpp:24: warning: Member signal_callback_handler(int signum) (function) of namespace shamsys::details is not documented.
- src/shamsys/src/SignalCatch.cpp:54: warning: Member register_signals() (function) of namespace shamsys is not documented.
- src/shamsys/src/SignalCatch.cpp:54: warning: Member register_signals() (function) of namespace shamsys is not documented.
- src/shamsys/src/SignalCatch.cpp:54: warning: Member register_signals() (function) of namespace shamsys is not documented.
+ src/shamsys/src/SignalCatch.cpp:83: warning: Member signal_callback_handler(int signum) (function) of namespace shamsys::details is not documented.
+ src/shamsys/src/SignalCatch.cpp:83: warning: Member signal_callback_handler(int signum) (function) of namespace shamsys::details is not documented.

tdavidcl added 4 commits February 8, 2026 11:41

fix for bug

c246227

fix for bug

5b0fda3

fix for bug

d526c32

[Base] add mem perf info to crash callstack report

eeda3a0

tdavidcl added draft light-ci labels Feb 8, 2026

tdavidcl added 2 commits February 8, 2026 20:21

Merge branch 'main' into aurora_scaling_test

a297fd3

Merge branch 'patch-2026-02-08-20-13' into aurora_scaling_test

c32b0fc

gemini-code-assist bot reviewed Feb 8, 2026

View reviewed changes

tdavidcl added 2 commits February 8, 2026 20:25

wait everywhere

3de42d2

wait everywhere

6e84c03

tdavidcl added 17 commits February 8, 2026 20:54

wait everywhere

530cb30

wait everywhere

9968f1b

make it fit in 2GB allocs

df63477

tidy up debug calls

e6c4f22

smaller injection step

c4d28ec

smaller injection step

9c9801f

ensure saxpy < i32_max

d53d7fa

Merge branch 'main' into aurora_scaling_test

da8a142

perform only safe copies

122bec1

noicer

491be01

use append from device buffer

a2c10e6

intercept sigkill and sigiot

b087ae5

intercept sigkill and sigiot

bc2c10e

mayyyybe

2a6a517

sync points

7cfefea

sync points

3674193

sync points

149f9e8

tdavidcl added 16 commits February 9, 2026 19:44

sync points

a6218ec

remove a print

51791f1

Merge branch 'main' into aurora_scaling_test

a345a8c

very safe indeed

eacfb41

more logs ?

5abf60c

log

ceece61

log

8eb91dd

potential overflow

57b2934

harden narrowing

f13a927

more debug

950be29

more checks

0948c97

fix ?

8f01860

Merge branch 'main' into aurora_scaling_test

d4d7b88

Merge branch 'main' into aurora_scaling_test

587f0d8

Merge branch 'main' into aurora_scaling_test

e1e81fe

Name all signals

10f743a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Stagging] Aurora tweaks#1625

[Stagging] Aurora tweaks#1625
tdavidcl wants to merge 41 commits intoShamrock-code:mainfrom
tdavidcl:aurora_scaling_test

tdavidcl commented Feb 8, 2026

Uh oh!

gemini-code-assist bot commented Feb 8, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Feb 8, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 8, 2026

Uh oh!

github-actions bot commented Feb 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	inline explicit SourceLocation(std::optional<std::string> _message = std::nullopt,srcloc _loc = srcloc::current()) : loc(_loc), message(_message) {}
	inline explicit SourceLocation(srcloc _loc = srcloc::current()) : loc(_loc), message(std::nullopt) {}
	inline explicit SourceLocation(std::string _message, srcloc _loc = srcloc::current()) : loc(_loc), message(std::move(_message)) {}

Conversation

tdavidcl commented Feb 8, 2026

Uh oh!

gemini-code-assist bot commented Feb 8, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 8, 2026

Uh oh!

github-actions bot commented Feb 28, 2026

Workflow report

Pre-commit check report

Doxygen diff with main

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Doxygen diff with `main`