[Patch] Follow up to #1531 - Layers: Add layers in layout, and replace it in scheduler#1701
Draft
aserhani wants to merge 21 commits intoShamrock-code:mainfrom
Draft
[Patch] Follow up to #1531 - Layers: Add layers in layout, and replace it in scheduler#1701aserhani wants to merge 21 commits intoShamrock-code:mainfrom
aserhani wants to merge 21 commits intoShamrock-code:mainfrom
Conversation
Contributor
|
Thanks @aserhani for opening this PR! You can do multiple things directly here: Once the workflow completes a message will appear displaying informations related to the run. Also the PR gets automatically reviewed by gemini, you can: |
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant architectural change by implementing a multi-layered data layout system. The new Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a PatchDataLayout to manage multiple data layers, which is a good step towards more complex simulations. The changes correctly replace the old PatchDataLayerLayout in most places. My review focuses on improving consistency and leveraging modern C++ features.
A recurring point is the access to the default layer. In some places, it's accessed by index 0, while in others by name "main". Using the name is more robust and readable. I've suggested changes to consistently use "main".
I've also pointed out opportunities to simplify code by removing redundant checks and using helper functions, and to modernize some C++ constructs for better maintainability.
Comment on lines
+48
to
+54
| PatchDataLayout(const std::vector<std::string> &layer_names) | ||
| : layer_layouts{layer_names.size()} { | ||
| for (size_t i = 0; i < layer_layouts.size(); i++) { | ||
| layer_layouts[i].name = layer_names[i]; | ||
| layer_layouts[i].layout = std::make_shared<PatchDataLayerLayout>(); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
This constructor can be implemented more idiomatically using modern C++ features like reserve and push_back with an initializer list. This avoids default-constructing LayerEntry objects and then re-assigning their members, which is slightly more efficient and readable.
PatchDataLayout(const std::vector<std::string> &layer_names) {
layer_layouts.reserve(layer_names.size());
for (const auto &name : layer_names) {
layer_layouts.push_back({std::make_shared<PatchDataLayerLayout>(), name});
}
}
Comment on lines
+61
to
+69
| size_t get_layer_index(const std::string &name) const { | ||
| for (size_t i = 0; i < layer_layouts.size(); i++) { | ||
| if (layer_layouts[i].name == name) { | ||
| return i; | ||
| } | ||
| } | ||
| throw shambase::make_except_with_loc<std::invalid_argument>( | ||
| "the requested layer does not exists"); | ||
| } |
Contributor
There was a problem hiding this comment.
This loop can be replaced with std::find_if from the <algorithm> header for a more idiomatic C++ implementation. You will need to include <algorithm> and <iterator>.
size_t get_layer_index(const std::string &name) const {
auto it = std::find_if(layer_layouts.begin(), layer_layouts.end(),
[&name](const LayerEntry &entry) {
return entry.name == name;
});
if (it != layer_layouts.end()) {
return std::distance(layer_layouts.begin(), it);
}
throw shambase::make_except_with_loc<std::invalid_argument>(
"the requested layer does not exists");
}| auto &pdl = *pdl_ptr; | ||
| std::shared_ptr<shamrock::patch::PatchDataLayout> pdl_ptr | ||
| = std::make_shared<shamrock::patch::PatchDataLayout>(std::vector<std::string>{"main"}); | ||
| auto &pdl = pdl_ptr->get_layer_ref(0); |
Contributor
There was a problem hiding this comment.
For consistency and readability, it's better to access the layer by its name "main" instead of its index 0.
auto &pdl = pdl_ptr->get_layer_ref("main");
Comment on lines
+18
to
+20
| auto &layer1 = pdl.get_layer_ref(0); | ||
| auto &layer2 = pdl.get_layer_ref(1); | ||
| auto &layer3 = pdl.get_layer_ref(2); |
Contributor
There was a problem hiding this comment.
Accessing layers by name instead of index would make this test more robust against changes in layer order.
auto &layer1 = pdl.get_layer_ref("layer1");
auto &layer2 = pdl.get_layer_ref("layer2");
auto &layer3 = pdl.get_layer_ref("layer3");
Comment on lines
+76
to
+78
| PatchDataLayout pdl_ref = PatchDataLayout(); | ||
| pdl_ref.layer_layouts.push_back( | ||
| PatchDataLayout::LayerEntry{std::make_shared<PatchDataLayerLayout>(pdl_layer), "main"}); |
Contributor
There was a problem hiding this comment.
It's better to use the public API to construct the reference object for the test. This makes the test clearer and also tests the class's public interface.
PatchDataLayout pdl_ref({"main"});
pdl_ref.get_layer_ref("main") = pdl_layer;References
- In tests, prefer programmatic construction of expected data collections over manual, verbose initialization to improve maintainability and robustness.
| auto &layout = *layout_ptr; | ||
| std::shared_ptr<PatchDataLayout> layout_ptr | ||
| = std::make_shared<PatchDataLayout>(std::vector<std::string>{"main"}); | ||
| auto &layout = layout_ptr->get_layer_ref(0); |
Contributor
There was a problem hiding this comment.
For consistency and readability, it's better to access the layer by its name "main" instead of its index 0.
auto &layout = layout_ptr->get_layer_ref("main");
Contributor
Workflow reportworkflow report corresponding to commit 755eddc Pre-commit check reportPre-commit check: ✅ Test pipeline can run. Clang-tidy diff reportSuggested changesDetailed changes :diff --git a/src/shampylib/src/pyShamrockCtx.cpp b/src/shampylib/src/pyShamrockCtx.cpp
index d9421a02..7579d4e2 100644
--- a/src/shampylib/src/pyShamrockCtx.cpp
+++ b/src/shampylib/src/pyShamrockCtx.cpp
@@ -108,7 +108,7 @@ Register_pymod(pyshamrockctxinit) {
}
using namespace shamrock;
- for (auto fname : ctx.pdl->get_layer_ref(0).get_field_names()) {
+ for (const auto& fname : ctx.pdl->get_layer_ref(0).get_field_names()) {
append_to_map<f32>(fname, data, dic_out);
append_to_map<f32_2>(fname, data, dic_out);
append_to_map<f32_3>(fname, data, dic_out);
diff --git a/src/shamrock/include/shamrock/scheduler/ShamrockCtx.hpp b/src/shamrock/include/shamrock/scheduler/ShamrockCtx.hpp
index f3f0303b..befa220d 100644
--- a/src/shamrock/include/shamrock/scheduler/ShamrockCtx.hpp
+++ b/src/shamrock/include/shamrock/scheduler/ShamrockCtx.hpp
@@ -23,6 +23,7 @@
#include <map>
#include <memory>
#include <tuple>
+#include <utility>
#include <vector>
class ShamAPIException : public std::exception {
@@ -84,7 +85,7 @@ class ShamrockCtx {
if (sched) {
throw ShamAPIException("cannot modify patch data layout while the scheduler is on");
}
- shambase::get_check_ref(pdl).get_layer_ref("main").add_field_t(fname, nvar, type);
+ shambase::get_check_ref(pdl).get_layer_ref("main").add_field_t(std::move(fname), nvar, std::move(type));
}
inline void pdata_layout_print() {Detailed changes :+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:100: warning: Member gen_ghost_handler(Tscal time_val) (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:101: warning: Member reset_ghost_handler() (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:103: warning: Member build_ghost_cache() (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:104: warning: Member clear_ghost_cache() (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:105: warning: Member build_ghost_cache() (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:106: warning: Member clear_ghost_cache() (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:106: warning: Member merge_position_ghost() (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:108: warning: Member merge_position_ghost() (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:109: warning: Member RTree (typedef) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:110: warning: Member build_merged_pos_trees() (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:111: warning: Member RTree (typedef) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:111: warning: Member clear_merged_pos_trees() (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:112: warning: Member build_merged_pos_trees() (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:113: warning: Member clear_merged_pos_trees() (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:113: warning: Member compute_presteps_rint() (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:114: warning: Member reset_presteps_rint() (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:115: warning: Member compute_presteps_rint() (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:116: warning: Member reset_presteps_rint() (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:116: warning: Member start_neighbors_cache() (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:117: warning: Member reset_neighbors_cache() (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:118: warning: Member start_neighbors_cache() (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:119: warning: Member gsph_prestep(Tscal time_val, Tscal dt) (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:119: warning: Member reset_neighbors_cache() (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:121: warning: Member apply_position_boundary(Tscal time_val) (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:121: warning: Member gsph_prestep(Tscal time_val, Tscal dt) (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:123: warning: Member apply_position_boundary(Tscal time_val) (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:123: warning: Member do_predictor_leapfrog(Tscal dt) (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:125: warning: Member do_predictor_leapfrog(Tscal dt) (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:125: warning: Member init_ghost_layout() (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:127: warning: Member communicate_merge_ghosts_fields() (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:127: warning: Member init_ghost_layout() (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:128: warning: Member reset_merge_ghosts_fields() (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:129: warning: Member communicate_merge_ghosts_fields() (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:130: warning: Member compute_omega() (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:130: warning: Member reset_merge_ghosts_fields() (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:131: warning: Member compute_eos_fields() (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:132: warning: Member compute_omega() (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:132: warning: Member reset_eos_fields() (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:133: warning: Member compute_eos_fields() (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:134: warning: Member reset_eos_fields() (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:154: warning: Member prepare_corrector() (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:156: warning: Member prepare_corrector() (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:176: warning: Member apply_corrector(Tscal dt, u64 Npart_all) (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:178: warning: Member apply_corrector(Tscal dt, u64 Npart_all) (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:178: warning: Member update_sync_load_values() (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:180: warning: Member Solver(ShamrockCtx &context) (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:180: warning: Member update_sync_load_values() (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:182: warning: Member Solver(ShamrockCtx &context) (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:182: warning: Member init_solver_graph() (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:184: warning: Member init_solver_graph() (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:184: warning: Member vtk_do_dump(std::string filename, bool add_patch_world_id) (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:186: warning: Member print_timestep_logs() (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:186: warning: Member vtk_do_dump(std::string filename, bool add_patch_world_id) (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:188: warning: Member print_timestep_logs() (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:195: warning: Member evolve_once() (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:197: warning: Member evolve_once() (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:197: warning: Member evolve_once_time_expl(Tscal t_current, Tscal dt_input) (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:199: warning: Member evolve_once_time_expl(Tscal t_current, Tscal dt_input) (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:204: warning: Member evolve_until(Tscal target_time, i32 niter_max=-1) (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:206: warning: Member evolve_until(Tscal target_time, i32 niter_max=-1) (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:91: warning: Member gen_serial_patch_tree() (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:92: warning: Member reset_serial_patch_tree() (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:93: warning: Member gen_serial_patch_tree() (function) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:94: warning: Member reset_serial_patch_tree() (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:95: warning: Member GhostHandle (typedef) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:96: warning: Member GhostHandleCache (typedef) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:97: warning: Member GhostHandle (typedef) of class shammodels::gsph::Solver is not documented.
+ src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:98: warning: Member GhostHandleCache (typedef) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:98: warning: Member gen_ghost_handler(Tscal time_val) (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/gsph/include/shammodels/gsph/Solver.hpp:99: warning: Member reset_ghost_handler() (function) of class shammodels::gsph::Solver is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:54: warning: Member Solver(ShamrockCtx &context) (function) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:56: warning: Member Solver(ShamrockCtx &context) (function) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:56: warning: Member do_debug_vtk_dump(std::string filename) (function) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:58: warning: Member do_debug_vtk_dump(std::string filename) (function) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:58: warning: Member print_timestep_logs() (function) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:60: warning: Member print_timestep_logs() (function) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:69: warning: Member evolve_once_time_expl(Tscal t_current, Tscal dt_input) (function) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:71: warning: Member evolve_once_time_expl(Tscal t_current, Tscal dt_input) (function) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:76: warning: Member evolve_until(Tscal target_time, i32 niter_max) (function) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Solver.hpp:78: warning: Member evolve_until(Tscal target_time, i32 niter_max) (function) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:132: warning: Member reset_ghost_handler() (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:134: warning: Member reset_ghost_handler() (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:143: warning: Member RTree (typedef) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:145: warning: Member RTree (typedef) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:200: warning: Member Solver(ShamrockCtx &context) (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:202: warning: Member Solver(ShamrockCtx &context) (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:208: warning: Member set_debug_dump(bool _do_debug_dump, std::string _debug_dump_filename) (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:210: warning: Member set_debug_dump(bool _do_debug_dump, std::string _debug_dump_filename) (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:212: warning: Member print_timestep_logs() (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:214: warning: Member print_timestep_logs() (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:230: warning: Member evolve_until(Tscal target_time, i32 niter_max) (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:232: warning: Member evolve_until(Tscal target_time, i32 niter_max) (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:81: warning: Member gen_serial_patch_tree() (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:82: warning: Member reset_serial_patch_tree() (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:83: warning: Member gen_serial_patch_tree() (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:84: warning: Member reset_serial_patch_tree() (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:85: warning: Member GhostHandle (typedef) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:86: warning: Member GhostHandleCache (typedef) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:87: warning: Member GhostHandle (typedef) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:88: warning: Member GhostHandleCache (typedef) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:88: warning: Member gen_ghost_handler(Tscal time_val) (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:90: warning: Member gen_ghost_handler(Tscal time_val) (function) of class shammodels::sph::Solver is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataLayout.hpp:33: warning: Compound shamrock::patch::PatchDataLayout::LayerEntry is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataLayout.hpp:34: warning: Member layout (variable) of struct shamrock::patch::PatchDataLayout::LayerEntry is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataLayout.hpp:35: warning: Member name (variable) of struct shamrock::patch::PatchDataLayout::LayerEntry is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataLayout.hpp:37: warning: Member operator==(const LayerEntry &lhs, const LayerEntry &rhs) (friend) of struct shamrock::patch::PatchDataLayout::LayerEntry is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataLayout.hpp:44: warning: Member layer_layouts (variable) of class shamrock::patch::PatchDataLayout is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataLayout.hpp:48: warning: Member PatchDataLayout(const std::vector< std::string > &layer_names) (function) of class shamrock::patch::PatchDataLayout is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataLayout.hpp:56: warning: Member PatchDataLayout(std::initializer_list< std::string > layer_names) (function) of class shamrock::patch::PatchDataLayout is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataLayout.hpp:59: warning: Member get_layer_count() const (function) of class shamrock::patch::PatchDataLayout is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataLayout.hpp:61: warning: Member get_layer_index(const std::string &name) const (function) of class shamrock::patch::PatchDataLayout is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataLayout.hpp:71: warning: Member get_layer_ptr(size_t idx) (function) of class shamrock::patch::PatchDataLayout is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataLayout.hpp:75: warning: Member get_layer_ptr(size_t idx) const (function) of class shamrock::patch::PatchDataLayout is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataLayout.hpp:79: warning: Member get_layer_ref(size_t idx) (function) of class shamrock::patch::PatchDataLayout is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataLayout.hpp:83: warning: Member get_layer_ptr(const std::string &name) (function) of class shamrock::patch::PatchDataLayout is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataLayout.hpp:87: warning: Member get_layer_ptr(const std::string &name) const (function) of class shamrock::patch::PatchDataLayout is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataLayout.hpp:92: warning: Member get_layer_ref(const std::string &name) (function) of class shamrock::patch::PatchDataLayout is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataLayout.hpp:96: warning: Member operator==(const PatchDataLayout &lhs, const PatchDataLayout &rhs) (friend) of class shamrock::patch::PatchDataLayout is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:100: warning: Member PatchScheduler(const std::shared_ptr< shamrock::patch::PatchDataLayerLayout > &pdl_ptr, u64 crit_split, u64 crit_merge) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:107: warning: Member dump_status() (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:109: warning: Member update_local_load_value(std::function< u64(shamrock::patch::Patch)> load_function) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:114: warning: Member init_mpi_required_types() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:116: warning: Member free_mpi_required_types() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:118: warning: Member PatchScheduler(const std::shared_ptr< shamrock::patch::PatchDataLayout > &pdl_ptr, u64 crit_split, u64 crit_merge) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:118: warning: Member get_box_tranform() (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:121: warning: Member get_box_volume() (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:123: warning: Member should_resize_box(bool node_in) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:125: warning: Member dump_status() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:127: warning: Member update_local_load_value(std::function< u64(shamrock::patch::Patch)> load_function) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:136: warning: Member get_box_tranform() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:139: warning: Member get_box_volume() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:141: warning: Member should_resize_box(bool node_in) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:156: warning: Member make_patch_base_grid(std::array< u32, dim > patch_count) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:170: warning: Member format_patch_coord(shamrock::patch::Patch p) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:172: warning: Member check_patchdata_locality_corectness() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:174: warning: Member make_patch_base_grid(std::array< u32, dim > patch_count) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:175: warning: Member dump_local_patches(std::string filename) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:177: warning: Member gather_data(u32 rank) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:182: warning: PatchScheduler::add_root_patch has @param documentation sections but no arguments
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:188: warning: Member format_patch_coord(shamrock::patch::Patch p) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:190: warning: Member check_patchdata_locality_corectness() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:193: warning: Member dump_local_patches(std::string filename) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:195: warning: Member gather_data(u32 rank) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:200: warning: PatchScheduler::add_root_patch has @param documentation sections but no arguments
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:202: warning: Member sync_build_LB(bool global_patch_sync, bool balance_load) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:205: warning: Member get_patch_transform() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:220: warning: Member sync_build_LB(bool global_patch_sync, bool balance_load) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:223: warning: Member get_patch_transform() (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:242: warning: Member for_each_patch(Function &&fct) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:255: warning: Member for_each_global_patch(std::function< void(const shamrock::patch::Patch)> fct) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:260: warning: Member for_each_patch(Function &&fct) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:263: warning: Member for_each_local_patch(std::function< void(const shamrock::patch::Patch)> fct) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:271: warning: Member for_each_local_patchdata(std::function< void(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &)> fct) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:273: warning: Member for_each_global_patch(std::function< void(const shamrock::patch::Patch)> fct) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:280: warning: Member for_each_local_patch_nonempty(std::function< void(const shamrock::patch::Patch &)> fct) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:281: warning: Member for_each_local_patch(std::function< void(const shamrock::patch::Patch)> fct) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:289: warning: Member for_each_local_patchdata(std::function< void(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &)> fct) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:292: warning: Member get_patch_rank_owner(u64 patch_id) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:298: warning: Member for_each_local_patch_nonempty(std::function< void(const shamrock::patch::Patch &)> fct) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:298: warning: Member for_each_patchdata_nonempty(std::function< void(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &)> fct) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:310: warning: Member get_patch_rank_owner(u64 patch_id) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:311: warning: Member map_owned_patchdata(std::function< T(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &pdat)> fct) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:316: warning: Member for_each_patchdata_nonempty(std::function< void(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &)> fct) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:324: warning: Member distrib_data_local_to_all_simple(shambase::DistributedData< T > &src) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:329: warning: Member map_owned_patchdata(std::function< T(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &pdat)> fct) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:337: warning: Member distrib_data_local_to_all_load_store(shambase::DistributedData< T > &src) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:342: warning: Member distrib_data_local_to_all_simple(shambase::DistributedData< T > &src) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:348: warning: Member map_owned_patchdata_fetch_simple(std::function< T(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &pdat)> fct) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:355: warning: Member distrib_data_local_to_all_load_store(shambase::DistributedData< T > &src) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:361: warning: Member map_owned_patchdata_fetch_load_store(std::function< T(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &pdat)> fct) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:366: warning: Member map_owned_patchdata_fetch_simple(std::function< T(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &pdat)> fct) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:374: warning: Member map_owned_to_patch_field_simple(std::function< T(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &pdat)> fct) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:379: warning: Member map_owned_patchdata_fetch_load_store(std::function< T(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &pdat)> fct) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:380: warning: Member map_owned_to_patch_field_load_store(std::function< T(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &pdat)> fct) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:385: warning: Member get_rank_count() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:392: warning: Member map_owned_to_patch_field_simple(std::function< T(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &pdat)> fct) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:396: warning: Member get_total_obj_count() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:398: warning: Member map_owned_to_patch_field_load_store(std::function< T(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &pdat)> fct) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:403: warning: Member get_rank_count() (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:403: warning: Member rankgather_field(u32 field_idx) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:414: warning: Member get_total_obj_count() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:421: warning: Member rankgather_field(u32 field_idx) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:461: warning: Member compute_patch_field(Pfield &field, MPI_Datatype &dtype, Function &&lambda) (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:479: warning: Member compute_patch_field(Pfield &field, MPI_Datatype &dtype, Function &&lambda) (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:479: warning: Member get_node_set_edge_patchdata_layer_refs() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:497: warning: Member get_node_set_edge_patchdata_layer_refs() (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:500: warning: Member get_sim_box() (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:502: warning: Member serialize_patch_metadata() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:518: warning: Member get_sim_box() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:520: warning: Member serialize_patch_metadata() (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:61: warning: Member max_axis_patch_coord (variable) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:62: warning: Member max_axis_patch_coord (variable) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:62: warning: Member max_axis_patch_coord_length (variable) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:63: warning: Member max_axis_patch_coord_length (variable) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:64: warning: Member PatchTree (typedef) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:65: warning: Member PatchTree (typedef) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:65: warning: Member SchedulerPatchData (typedef) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:66: warning: Member SchedulerPatchData (typedef) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:67: warning: Member pdl_ptr (variable) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:68: warning: Member pdl_ptr (variable) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:80: warning: Member pdl_old() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:81: warning: Member pdl() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:83: warning: Member get_layout_ptr() const (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:84: warning: Member get_layout_ptr_old() const (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:96: warning: Member init_mpi_required_types() (function) of class PatchScheduler is not documented.
+ src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:97: warning: Member get_layout_ptr_old() const (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/PatchScheduler.hpp:98: warning: Member free_mpi_required_types() (function) of class PatchScheduler is not documented.
- src/shamrock/include/shamrock/scheduler/ShamrockCtx.hpp:105: warning: Member init_sched(u64 crit_split, u64 crit_merge) (function) of class ShamrockCtx is not documented.
+ src/shamrock/include/shamrock/scheduler/ShamrockCtx.hpp:106: warning: Member init_sched(u64 crit_split, u64 crit_merge) (function) of class ShamrockCtx is not documented.
- src/shamrock/include/shamrock/scheduler/ShamrockCtx.hpp:115: warning: Member close_sched() (function) of class ShamrockCtx is not documented.
+ src/shamrock/include/shamrock/scheduler/ShamrockCtx.hpp:116: warning: Member close_sched() (function) of class ShamrockCtx is not documented.
- src/shamrock/include/shamrock/scheduler/ShamrockCtx.hpp:125: warning: Member gather_data(u32 rank) (function) of class ShamrockCtx is not documented.
+ src/shamrock/include/shamrock/scheduler/ShamrockCtx.hpp:126: warning: Member gather_data(u32 rank) (function) of class ShamrockCtx is not documented.
- src/shamrock/include/shamrock/scheduler/ShamrockCtx.hpp:129: warning: Member allgather_data() (function) of class ShamrockCtx is not documented.
+ src/shamrock/include/shamrock/scheduler/ShamrockCtx.hpp:130: warning: Member allgather_data() (function) of class ShamrockCtx is not documented.
- src/shamrock/include/shamrock/scheduler/ShamrockCtx.hpp:147: warning: Member set_coord_domain_bound(std::tuple< f64_3, f64_3 > box) (function) of class ShamrockCtx is not documented.
+ src/shamrock/include/shamrock/scheduler/ShamrockCtx.hpp:148: warning: Member set_coord_domain_bound(std::tuple< f64_3, f64_3 > box) (function) of class ShamrockCtx is not documented.
- src/shamrock/include/shamrock/scheduler/ShamrockCtx.hpp:177: warning: Member scheduler_step(bool do_split_merge, bool do_load_balancing) (function) of class ShamrockCtx is not documented.
+ src/shamrock/include/shamrock/scheduler/ShamrockCtx.hpp:182: warning: Member scheduler_step(bool do_split_merge, bool do_load_balancing) (function) of class ShamrockCtx is not documented.
- src/shamrock/include/shamrock/scheduler/ShamrockCtx.hpp:184: warning: Member get_patch_list_global() (function) of class ShamrockCtx is not documented.
+ src/shamrock/include/shamrock/scheduler/ShamrockCtx.hpp:189: warning: Member get_patch_list_global() (function) of class ShamrockCtx is not documented.
- src/shamrock/include/shamrock/scheduler/ShamrockCtx.hpp:97: warning: Member dump_status() (function) of class ShamrockCtx is not documented.
+ src/shamrock/include/shamrock/scheduler/ShamrockCtx.hpp:98: warning: Member dump_status() (function) of class ShamrockCtx is not documented.
- src/shamrock/src/scheduler/PatchScheduler.cpp:253: warning: Member get_box_tranform() (function) of class PatchScheduler is not documented.
+ src/shamrock/src/scheduler/PatchScheduler.cpp:258: warning: Member get_box_tranform() (function) of class PatchScheduler is not documented.
- src/shamrock/src/scheduler/PatchScheduler.cpp:267: warning: Member get_box_tranform() (function) of class PatchScheduler is not documented.
+ src/shamrock/src/scheduler/PatchScheduler.cpp:272: warning: Member get_box_tranform() (function) of class PatchScheduler is not documented.
- src/shamrock/src/scheduler/PatchScheduler.cpp:281: warning: Member get_box_volume() (function) of class PatchScheduler is not documented.
+ src/shamrock/src/scheduler/PatchScheduler.cpp:286: warning: Member get_box_volume() (function) of class PatchScheduler is not documented.
- src/shamrock/src/scheduler/PatchScheduler.cpp:290: warning: Member get_box_volume() (function) of class PatchScheduler is not documented.
+ src/shamrock/src/scheduler/PatchScheduler.cpp:295: warning: Member get_box_volume() (function) of class PatchScheduler is not documented.
- src/shamrock/src/scheduler/PatchScheduler.cpp:299: warning: Member get_box_volume() (function) of class PatchScheduler is not documented.
+ src/shamrock/src/scheduler/PatchScheduler.cpp:304: warning: Member get_box_volume() (function) of class PatchScheduler is not documented.
- src/shamrock/src/scheduler/PatchScheduler.cpp:663: warning: Member check_locality_t(PatchScheduler &sched) (function) of file PatchScheduler.cpp is not documented.
+ src/shamrock/src/scheduler/PatchScheduler.cpp:668: warning: Member check_locality_t(PatchScheduler &sched) (function) of file PatchScheduler.cpp is not documented.
- src/shamrock/src/scheduler/PatchScheduler.cpp:891: warning: Compound Message is not documented.
- src/shamrock/src/scheduler/PatchScheduler.cpp:892: warning: Member buf (variable) of struct Message is not documented.
- src/shamrock/src/scheduler/PatchScheduler.cpp:893: warning: Member rank (variable) of struct Message is not documented.
- src/shamrock/src/scheduler/PatchScheduler.cpp:894: warning: Member tag (variable) of struct Message is not documented.
+ src/shamrock/src/scheduler/PatchScheduler.cpp:896: warning: Compound Message is not documented.
+ src/shamrock/src/scheduler/PatchScheduler.cpp:897: warning: Member buf (variable) of struct Message is not documented.
- src/shamrock/src/scheduler/PatchScheduler.cpp:897: warning: Member send_messages(std::vector< Message > &msgs, std::vector< MPI_Request > &rqs) (function) of file PatchScheduler.cpp is not documented.
+ src/shamrock/src/scheduler/PatchScheduler.cpp:898: warning: Member rank (variable) of struct Message is not documented.
+ src/shamrock/src/scheduler/PatchScheduler.cpp:899: warning: Member tag (variable) of struct Message is not documented.
+ src/shamrock/src/scheduler/PatchScheduler.cpp:902: warning: Member send_messages(std::vector< Message > &msgs, std::vector< MPI_Request > &rqs) (function) of file PatchScheduler.cpp is not documented.
- src/shamrock/src/scheduler/PatchScheduler.cpp:924: warning: Member recv_probe_messages(std::vector< Message > &msgs, std::vector< MPI_Request > &rqs) (function) of file PatchScheduler.cpp is not documented.
+ src/shamrock/src/scheduler/PatchScheduler.cpp:929: warning: Member recv_probe_messages(std::vector< Message > &msgs, std::vector< MPI_Request > &rqs) (function) of file PatchScheduler.cpp is not documented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.