Conversation
This comment has been minimized.
This comment has been minimized.
5af4754 to
6802b08
Compare
Contributor
Coverage report
Test suite run success1056 tests passing in 534 suites. Report generated by 🧪jest coverage report action from 6802b08 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
In order to avoid non-populated host themes, they should be populated every time, until Ruby CLI dependency has been removed.
WHAT is this pull request doing?
Treats a host theme as always
createdAtRuntime, so that--generate-tmp-themeis always passed to CLI 2.How to test your changes?
shopify app devin your favorite app directory.Measuring impact
How do we know this change was effective? Please choose one:
Checklist
devordeployhave been reflected in the internal flowchart.