Skip to content

Always populate host theme#1419

Merged
Arkham merged 1 commit intomainfrom
always-generate-tmp-cache
Feb 22, 2023
Merged

Always populate host theme#1419
Arkham merged 1 commit intomainfrom
always-generate-tmp-cache

Conversation

@Poitrin
Copy link
Copy Markdown
Contributor

@Poitrin Poitrin commented Feb 22, 2023

WHY are these changes introduced?

In order to avoid non-populated host themes, they should be populated every time, until Ruby CLI dependency has been removed.

WHAT is this pull request doing?

Treats a host theme as always createdAtRuntime, so that --generate-tmp-theme is always passed to CLI 2.

How to test your changes?

  • shopify app dev in your favorite app directory.

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@github-actions

This comment has been minimized.

@Poitrin Poitrin force-pushed the always-generate-tmp-cache branch from 5af4754 to 6802b08 Compare February 22, 2023 10:44
@github-actions
Copy link
Copy Markdown
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 72.83% 4146/5693
🟡 Branches 69.63% 1871/2687
🟡 Functions 70.33% 1095/1557
🟡 Lines 74.12% 3956/5337

Test suite run success

1056 tests passing in 534 suites.

Report generated by 🧪jest coverage report action from 6802b08

Copy link
Copy Markdown
Contributor

@Arkham Arkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Arkham Arkham merged commit 245af03 into main Feb 22, 2023
@Arkham Arkham deleted the always-generate-tmp-cache branch February 22, 2023 11:14
@shopify-shipit shopify-shipit Bot temporarily deployed to nightly February 22, 2023 12:56 Inactive
@shopify-shipit shopify-shipit Bot temporarily deployed to production February 22, 2023 16:13 Inactive
@shopify-shipit shopify-shipit Bot temporarily deployed to stable_3_44 February 23, 2023 11:03 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants