As soon as #743 has been merged: Allow --force flag for theme dev/pull/push/share, support flag for share#764
Closed
As soon as #743 has been merged: Allow --force flag for theme dev/pull/push/share, support flag for share#764
--force flag for theme dev/pull/push/share, support flag for share#764Conversation
--force flag for theme dev/pull/push/share, support flag for share--force flag for theme dev/pull/push/share, support flag for share
Contributor
|
We detected some changes at packages/*/src and there are no updates in the .changeset. |
6 tasks
Contributor
|
I believe I integrated these changes into #743, but feel free to check my work before closing. |
Contributor
Author
Merged → Closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Follow-up PR for #751 (already merged) and #743 (needs to be merged into
mainfirst)WHAT is this pull request doing?
--forceto theme dev/pull/push/share commands--forceflag fortheme sharecommand (forgot to add it in Add--forceflag for validation onshopify theme dev/pull/push/shareif users are running the command in a theme directory #751)theme pull --force(forgot to set it correctly in Add--forceflag for validation onshopify theme dev/pull/push/shareif users are running the command in a theme directory #751)How to test your changes?
cdinto a directory that is not a valid theme directory (i.e. does not have the 4 folders config, layout, sections, templates)--forceflag?--forceflag?Post-release steps
–
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
devordeployhave been reflected in the internal flowchart.