Skip to content

As soon as #743 has been merged: Allow --force flag for theme dev/pull/push/share, support flag for share#764

Closed
Poitrin wants to merge 4 commits intomainfrom
fix-theme-pass-through-flags-julien
Closed

As soon as #743 has been merged: Allow --force flag for theme dev/pull/push/share, support flag for share#764
Poitrin wants to merge 4 commits intomainfrom
fix-theme-pass-through-flags-julien

Conversation

@Poitrin
Copy link
Copy Markdown
Contributor

@Poitrin Poitrin commented Nov 11, 2022

WHY are these changes introduced?

Follow-up PR for #751 (already merged) and #743 (needs to be merged into main first)

WHAT is this pull request doing?

How to test your changes?

  • cd into a directory that is not a valid theme directory (i.e. does not have the 4 folders config, layout, sections, templates)
  • call any of the theme commands
  • does a confirmation dialogue show up without the --force flag?
  • does no confirmation dialogue show up with the --force flag?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@Poitrin Poitrin changed the title Allow --force flag for theme dev/pull/push/share, support flag for share As soon as #743 has been merged: Allow --force flag for theme dev/pull/push/share, support flag for share Nov 11, 2022
@Poitrin Poitrin marked this pull request as ready for review November 11, 2022 12:32
@Poitrin Poitrin requested a review from a team November 11, 2022 12:32
@github-actions
Copy link
Copy Markdown
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "yarn changeset add" to track your changes and include them in the next release CHANGELOG.

@amcaplan
Copy link
Copy Markdown
Contributor

I believe I integrated these changes into #743, but feel free to check my work before closing.

@Poitrin
Copy link
Copy Markdown
Contributor Author

Poitrin commented Nov 29, 2022

I believe I integrated these changes into #743, but feel free to check my work before closing.

Merged main into this branch, and can confirm that – besides some auto-formatting changes and a super tiny change of the command description in packages/theme/src/cli/commands/theme/pull.ts – all my changes of this branch are already on main.

Closed.

@Poitrin Poitrin closed this Nov 29, 2022
@Poitrin Poitrin deleted the fix-theme-pass-through-flags-julien branch November 29, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants