Skip to content

Open auth browser without keypress prompt#7668

Merged
gonzaloriestra merged 1 commit into
mainfrom
open-auth-browser-directly
Jun 12, 2026
Merged

Open auth browser without keypress prompt#7668
gonzaloriestra merged 1 commit into
mainfrom
open-auth-browser-directly

Conversation

@gonzaloriestra

@gonzaloriestra gonzaloriestra commented May 29, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Fixes https://github.com/shop/issues-develop/issues/22867

The login flow currently pauses in interactive terminals and asks users to press a key before Shopify CLI opens the browser. We want authentication to start directly by opening the browser, making it easier for agents.

WHAT is this pull request doing?

  • Removes the keypress() wait and "Press any key" message from the interactive device auth flow.
  • Keeps the existing manual-link fallback when the browser can't be opened.

How to test your changes?

shopify auth login

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

@github-actions github-actions Bot added the Area: @shopify/cli @shopify/cli package issues label May 29, 2026
Comment thread packages/cli-kit/src/private/node/session/device-authorization.ts
@gonzaloriestra
gonzaloriestra force-pushed the open-auth-browser-directly branch from 71132c0 to 5fed826 Compare June 1, 2026 08:46
@gonzaloriestra
gonzaloriestra force-pushed the open-auth-browser-directly branch from 5fed826 to 334e2d4 Compare June 2, 2026 09:05
@gonzaloriestra

Copy link
Copy Markdown
Contributor Author

/snapit

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260602104654

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@gonzaloriestra
gonzaloriestra marked this pull request as ready for review June 9, 2026 12:22
@gonzaloriestra
gonzaloriestra requested review from a team as code owners June 9, 2026 12:22

gonzaloriestra commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Jun 12, 9:27 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 12, 9:27 AM UTC: @gonzaloriestra added this pull request to the GitHub merge queue with Graphite.

@gonzaloriestra
gonzaloriestra added this pull request to the merge queue Jun 12, 2026
Merged via the queue into main with commit 93e111a Jun 12, 2026
28 checks passed
@gonzaloriestra
gonzaloriestra deleted the open-auth-browser-directly branch June 12, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: @shopify/cli @shopify/cli package issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants