Skip to content

Omit admin URL for preview stores in store info #7858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amcaplan merged 1 commit into from
Jun 19, 2026
Merged

Omit admin URL for preview stores in store info #7858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/store/src/cli/services/store/info/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,10 +185,11 @@ describe('getStoreInfo', () => {
id: 'gid://shopify/Shop/123',
displayName: 'Lavender Candles',
subdomain: SHOP,
adminUrl: 'https://admin.shopify.com/store/shop',
accessUrl: 'https://app.shopify.com/auth/preview-store?token=fresh-access-token',
saveUrl: 'https://admin.shopify.com/store-transfer/accept/claim-token',
})
// The admin URL doesn't resolve for an unclaimed preview store, so it's deliberately omitted.
expect(result.adminUrl).toBeUndefined()
})

test('prefers BP when store auth exists and BP can resolve the store', async () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/store/src/cli/services/store/info/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,10 +242,10 @@ function buildPreviewStoreResult(args: {
previewStoreUrls: PreviewStoreUrls
}): StoreInfoResult {
const {store, previewSession, previewStoreUrls} = args
// The admin URL is intentionally omitted: it doesn't resolve for an unclaimed preview store yet.
const fields: Partial<StoreInfoResult> = {
id: buildShopGid(previewSession.preview.shopId),
displayName: previewSession.preview.name,
adminUrl: buildAdminUrl(extractMyshopifyHandle(store)),
accessUrl: previewStoreUrls.accessUrl,
saveUrl: previewStoreUrls.saveUrl,
}
Expand Down
Loading