Skip to content

Move seo to hydrogen package#389

Merged
cartogram merged 11 commits into
v0.x-2022-10from
move-seo-to-h2
Jan 25, 2023
Merged

Move seo to hydrogen package#389
cartogram merged 11 commits into
v0.x-2022-10from
move-seo-to-h2

Conversation

@cartogram
Copy link
Copy Markdown
Contributor

@cartogram cartogram commented Jan 24, 2023

The diff here is a bit whack, but this PR mostly just moves the lib/seo code to hydrogen/src/seo and renamed some files.

Most of the small changes are this:

- import {Seo, type SeoHandleFunction} from '~/lib/seo';
+ import {Seo, type SeoHandleFunction} from '@shopify/hydrogen';

Note the generate-seo-tags.ts file is moving to storefront-kit.

@cartogram cartogram requested a review from a team January 24, 2023 21:27
@github-actions
Copy link
Copy Markdown
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset.
If the changes are user-facing and should cause a version bump, run npm run changeset add to track your changes and include them in the next release CHANGELOG.
If you are making simple updates to examples or documentation, you do not need to add a changeset.

@github-actions github-actions Bot had a problem deploying to preview January 24, 2023 21:31 Failure
@cartogram cartogram marked this pull request as draft January 24, 2023 21:34
@github-actions github-actions Bot had a problem deploying to preview January 24, 2023 21:35 Failure
@github-actions github-actions Bot had a problem deploying to preview January 25, 2023 02:29 Failure
@github-actions github-actions Bot had a problem deploying to preview January 25, 2023 02:37 Failure
@github-actions github-actions Bot had a problem deploying to preview January 25, 2023 03:28 Failure
Copy link
Copy Markdown
Contributor

@jplhomer jplhomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. It makes sense.

@cartogram cartogram merged commit d8a76aa into v0.x-2022-10 Jan 25, 2023
@cartogram cartogram deleted the move-seo-to-h2 branch January 25, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants