Fix discount route#601
Merged
Merged
Conversation
juanpprieto
approved these changes
Mar 1, 2023
frehner
approved these changes
Mar 1, 2023
Contributor
frehner
left a comment
frehner
left a comment
There was a problem hiding this comment.
The changeset is a good way to notify. Also, don't we warn devs if they don't have standard routes? So does this update mean that if they have a discounts route they'll now have a new warning about not having a discount route?
| @@ -0,0 +1,5 @@ | |||
| --- | |||
lordofthecactus
approved these changes
Mar 1, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standard route is supposed to be
/discount/<code>instead of the existing/discounts/<code>.The deployed version is now redirecting correctly: deployed-PR/discount/SHIPPING
What's the best way to inform of these changes in the demo-store to existing users?