Adding image decoding#642
Merged
Merged
Conversation
cartogram
reviewed
Mar 7, 2023
bcaf499 to
f4c8762
Compare
Contributor
|
@rafaelstz thanks for this contribution. Could you please add a
|
Contributor
Author
|
All set @juanpprieto |
blittle
approved these changes
Mar 13, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The decoding property is auto by default, but in order to improve the LCP and CLS scores we can use it as sync to prioritize it.
Introducing these changes, give the dev the possibility to use it in other image elements easier.
WHAT is this pull request doing?
Adding the decoding='sync' to Hero images and adding the decoding capability to the SpreadMedia component.
HOW to test your changes?
Through the Network tab, check the feels like during the loading, the prioritization, and the browser compatibilities.
https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement/decoding
Post-merge steps
Checklist