Fix bug in create CLI using --install-deps flag#644
Merged
Conversation
frandiox
approved these changes
Mar 6, 2023
Contributor
frandiox
left a comment
frandiox
left a comment
There was a problem hiding this comment.
Oh good catch! Though I think it would be better to call flagsToCamelObject in line 49 (await runInit(flagsToCamelObject({...flags}))) like we do in other commands. Can you change that?
Contributor
Author
|
@frandiox oh yes! I forgot about that util, thanks! |
cartogram
commented
Mar 6, 2023
| @@ -0,0 +1,93 @@ | |||
| import {describe, it, expect, vi, beforeEach} from 'vitest'; | |||
Contributor
Author
There was a problem hiding this comment.
@frandiox I just added these tests as well.
cartogram
force-pushed
the
@cartogram/fix-cli-deps-install
branch
from
fa5d155 to
a002a00
Compare
cartogram
force-pushed
the
@cartogram/fix-cli-deps-install
branch
from
a002a00 to
934aca7
Compare
frandiox
approved these changes
Mar 7, 2023
Contributor
frandiox
left a comment
frandiox
left a comment
There was a problem hiding this comment.
Thanks for the tests! LGTM 👍
Merged
juanpprieto
pushed a commit
that referenced
this pull request
Mar 7, 2023
* Fix bug in create CLI using `--install-deps` flag * Use flags to camel case util * Add tests for init --------- Co-authored-by: Matt Seccafien <462077+cartogram@users.noreply.github.com>
juanpprieto
added a commit
that referenced
this pull request
Mar 7, 2023
…ed] (#660) * refactor seo and implement ld+json structured data * Update templates/demo-store/app/lib/seo.server.ts Co-authored-by: Matt Seccafien <matt.seccafien@shopify.com> * Update templates/demo-store/app/routes/($lang)/search.tsx Co-authored-by: Matt Seccafien <matt.seccafien@shopify.com> * Fix bug in create CLI using `--install-deps` flag (#644) * Fix bug in create CLI using `--install-deps` flag * Use flags to camel case util * Add tests for init --------- Co-authored-by: Matt Seccafien <462077+cartogram@users.noreply.github.com> * Hero images loading eager (#641) * Remove Turbo cache in Oxygen deplyment (#655) Co-authored-by: Matt Seccafien <462077+cartogram@users.noreply.github.com> * Remove Turbo cache from typescript build action (#656) Co-authored-by: Matt Seccafien <462077+cartogram@users.noreply.github.com> * fix search products count fix search products count --------- Co-authored-by: Matt Seccafien <matt.seccafien@shopify.com> Co-authored-by: Matt Seccafien <462077+cartogram@users.noreply.github.com> Co-authored-by: Rafael Corrêa Gomes <rafaelstz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The
--install-depsand--no-install-depsflags were being ignored in theinitcommand.WHAT is this pull request doing?
Fixes the casing of the flag.
Post-merge steps
Checklist