(demo-store): Improve Shopify analytics implementation#666
Closed
juanpprieto wants to merge 3 commits into
Closed
Conversation
blittle
approved these changes
Mar 13, 2023
wizardlyhel
suggested changes
Mar 13, 2023
wizardlyhel
left a comment
There was a problem hiding this comment.
Let's hold this for now. I do like the cleanness in the route but I also would also want the demo store implementation be reflected in developer docs.
Contributor
|
Closing, but if you feel like this is still applicable please reopen and resolve conflicts! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Improve the demo store Shopify analytics implementation by ensuring all applicable routes return
analyticsmetadata in the loader.This PR creates better synergy between
seoandanlyticswith a payload helper. For more info see the seo PR.WHAT is this pull request doing?
analyticsPayloadto help manage shopify analytics payloads in a centralized location~/libs/analytics.server.tsanalyticsPayloadhelperExample implementation product route
similar helper for all other routes...
Checklist